Skip Menu |
 

This queue is for tickets about the Module-CPANTS-Analyse CPAN distribution.

Report information
The Basics
Id: 114247
Status: patched
Priority: 0/
Queue: Module-CPANTS-Analyse

People
Owner: Nobody in particular
Requestors: IKEGAMI [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: Module::CPANTS::Kwalitee::License doesn't look for LICENSE.txt
MIME-Version: 1.0
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
Message-ID: <rt-4.0.18-14464-1462764958-150.0-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 162
Download (untitled) / with headers
text/plain 162b
CPAN has accepted LICENSE.txt as the license file for as long as I've known about it, but Module::CPANTS::Kwalitee::License does not look for it under that name.
MIME-Version: 1.0
In-Reply-To: <rt-4.0.18-14464-1462764958-150.0-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <rt-4.0.18-14464-1462764958-150.0-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.18-11843-1462773418-431.114247-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 437
Download (untitled) / with headers
text/plain 437b
On 2016-05-08 20:35:58, ikegami wrote: Show quoted text
> CPAN has accepted LICENSE.txt as the license file for as long as I've > known about it, but Module::CPANTS::Kwalitee::License does not look > for it under that name.
Do you know what bit of code looks for that file? It would be helpful to use as a reference to make sure all the variants are covered, as well as documented elsewhere (e.g. any toolchain standards documents still to be written).
MIME-Version: 1.0
In-Reply-To: <rt-4.0.18-14464-1462764958-150.0-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <rt-4.0.18-14464-1462764958-150.0-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.18-17437-1462781051-790.114247-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 338
Download (untitled) / with headers
text/plain 338b
On Mon May 09 12:35:58 2016, ikegami wrote: Show quoted text
> CPAN has accepted LICENSE.txt as the license file for as long as I've > known about it, but Module::CPANTS::Kwalitee::License does not look > for it under that name.
Thanks. Fixed in the master: https://github.com/cpants/Module-CPANTS-Analyse/commit/6018f9778c42576041fa46bea35d3a9e19cb3467
CC: IKEGAMI [...] cpan.org
MIME-Version: 1.0
X-Spam-Status: No, score=-5.598 tagged_above=-99.9 required=10 tests=[AWL=1.000, BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, FROM_OUR_RT=-4, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=ham
In-Reply-To: <rt-4.0.18-17437-1462781051-83.114247-6-0 [...] rt.cpan.org>
X-Spam-Flag: NO
X-RT-Interface: API
References: <RT-Ticket-114247 [...] rt.cpan.org> <rt-4.0.18-14464-1462764958-150.114247-6-0 [...] rt.cpan.org> <rt-4.0.18-17437-1462781051-83.114247-6-0 [...] rt.cpan.org>
X-Virus-Checked: Checked
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
X-Received: by 10.60.70.144 with SMTP id m16mr7817779oeu.60.1462798210912; Mon, 09 May 2016 05:50:10 -0700 (PDT)
Message-ID: <CALJW-qEwLNZENyuj9A=shw=gpn1SYh2t-4YjnBvtoOy03==s6A [...] mail.gmail.com>
Content-Type: multipart/alternative; boundary="001a11333b66bd5add0532683fa9"
X-Spam-Score: -5.598
Authentication-Results: hipster.bestpractical.com (amavisd-new); dkim=pass header.i= [...] gmail.com
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id DA74D2401D9 for <cpan-bug+Module-CPANTS-Analyse [...] hipster.bestpractical.com>; Mon, 9 May 2016 08:50:21 -0400 (EDT)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bbN3UhPtdVHn for <cpan-bug+Module-CPANTS-Analyse [...] hipster.bestpractical.com>; Mon, 9 May 2016 08:50:20 -0400 (EDT)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id B925E240030 for <bug-Module-CPANTS-Analyse [...] rt.cpan.org>; Mon, 9 May 2016 08:50:19 -0400 (EDT)
Received: (qmail 18739 invoked by alias); 9 May 2016 12:50:19 -0000
Received: from mail-ob0-f179.google.com (HELO mail-ob0-f179.google.com) (209.85.214.179) by la.mx.develooper.com (qpsmtpd/0.28) with ESMTP; Mon, 09 May 2016 05:50:15 -0700
Received: by mail-ob0-f179.google.com with SMTP id n10so82503026obb.2 for <bug-Module-CPANTS-Analyse [...] rt.cpan.org>; Mon, 09 May 2016 05:50:14 -0700 (PDT)
Received: by 10.182.122.104 with HTTP; Mon, 9 May 2016 05:50:10 -0700 (PDT)
Delivered-To: cpan-bug+Module-CPANTS-Analyse [...] hipster.bestpractical.com
Subject: Re: [rt.cpan.org #114247] Module::CPANTS::Kwalitee::License doesn't look for LICENSE.txt
Return-Path: <ikesuke [...] gmail.com>
Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc; bh=ZkfBz3tLBL3ySnAXzA2u1HHa7hPDB5KVJROs5ygl440=; b=AdVHBdGIf23qJd5ydsMxllhCErowqrv7Om18/wYDCL4+4p8SHNY7exrco+S5Mk6GV8 7CI4n5PwYVCKWcGgx5Jl7/8NbXtdMznM718eC05PaYqKh5TC9zOZqA8KSIioA8idIzAp T9d77JM3hQ+m81Jn7dtuFp5wadmm69MydHdunVEUj+QW4ml+XwhD0dN0WPubMyq2N9kl xZ2tplotZBChgcO5jCCWinsvgPD+ttD0rpJWXigCaECnuCeO8JEZGGYm+bEfE1c+8sSf LoTUtw2UVbDBNKb/kzndX6JJM1z8woA9FcNw+7Uxy00ao6b609Md/ecewj5EYO6wf3yR PLSw==
X-Spam-Check-BY: la.mx.develooper.com
X-Original-To: cpan-bug+Module-CPANTS-Analyse [...] hipster.bestpractical.com
X-RT-Mail-Extension: module-cpants-analyse
X-Google-Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:date :message-id:subject:from:to:cc; bh=ZkfBz3tLBL3ySnAXzA2u1HHa7hPDB5KVJROs5ygl440=; b=UqoHsslS1Q/p1nhHtL2mjyACnxxUDJ6wUqe+LVHhKn8g3BxaPniArU6StxGc8ZM3Tb wkyeYpBetqcW0dCPG1IUyYkbWnEYCtBmdjX+gcmCxi0bIxFbFHlMy6zu54kK5edgOXzC YZQMTcruwAos3m9T3uyuGZJkhytV9fOo3OwyBpaBVnTI5ux8TzKIzGbBSr7ECwja7rwM MCdhp0+Q+DAi1osEf8q+XyrwfisiJ5oXF8qPHfm1UA/X6UPy/RKdxNwEOBfhEecgGfUT X7yYBg8T+77M1qWi+wkt+AipvIUNcJ9F9gRMv8mAQlKdQM88ygjlKDMgLognNjR79Nvt 4qSQ==
X-Google-Sender-Auth: 2ThCOoClefvBiXqAyYTdCUOQ83c
Sender: ikesuke [...] gmail.com
Date: Mon, 9 May 2016 08:50:10 -0400
X-Spam-Level:
To: bug-Module-CPANTS-Analyse [...] rt.cpan.org
X-GM-Message-State: AOPr4FUH+HZJTfpaP4os/3eK5xXrWWnPd2UGO2Yke1u6aP0g8owEbbA0zlSeGH1l0JVGkUBRoJdV79Vx26BPaA==
From: Eric Brine <ikegami [...] adaelis.com>
RT-Message-ID: <rt-4.0.18-9152-1462798223-831.114247-0-0 [...] rt.cpan.org>
Content-Length: 0
content-type: text/plain; charset="utf-8"
X-RT-Original-Encoding: utf-8
Content-Length: 1576
Download (untitled) / with headers
text/plain 1.5k
Thanks, but you may want to revert that. I just learned that metacpan is much more strict about which meta files it lists as compared to search.cpan.org. Apparently, it's been hiding distros' README.txt and LICENSE.txt all this time, whereas these were picked up by search.cpan.org. Specifically, I think metacpan only lists the following: AUTHORS Build.PL Changelog ChangeLog CHANGELOG Changes CHANGES CONTRIBUTING CONTRIBUTING.md CONTRIBUTING.pod Copying COPYRIGHT cpanfile CREDITS dist.ini FAQ INSTALL INSTALL.md INSTALL.pod LICENSE Makefile.PL MANIFEST META.json META.yml NEWS README README.md README.pod THANKS Todo ToDo TODO I'm going to put more research into what's actually being used by modules, then propose a fix for metacpan and one for Module::CPANTS::Kwalitee::License. - Eric On Mon, May 9, 2016 at 4:04 AM, Kenichi Ishigaki via RT < bug-Module-CPANTS-Analyse@rt.cpan.org> wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=114247 > > > On Mon May 09 12:35:58 2016, ikegami wrote:
> > CPAN has accepted LICENSE.txt as the license file for as long as I've > > known about it, but Module::CPANTS::Kwalitee::License does not look > > for it under that name.
> > Thanks. Fixed in the master: > https://github.com/cpants/Module-CPANTS-Analyse/commit/6018f9778c42576041fa46bea35d3a9e19cb3467 > >
content-type: text/html; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
X-RT-Original-Encoding: utf-8
Content-Length: 2917
MIME-Version: 1.0
In-Reply-To: <rt-4.0.18-9152-1462798223-831.114247-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <RT-Ticket-114247 [...] rt.cpan.org> <rt-4.0.18-14464-1462764958-150.114247-6-0 [...] rt.cpan.org> <rt-4.0.18-17437-1462781051-83.114247-6-0 [...] rt.cpan.org> <CALJW-qEwLNZENyuj9A=shw=gpn1SYh2t-4YjnBvtoOy03==s6A [...] mail.gmail.com> <rt-4.0.18-9152-1462798223-831.114247-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.18-4310-1462813811-1761.114247-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 590
Download (untitled) / with headers
text/plain 590b
On 2016-05-09 05:50:23, ikegami@adaelis.com wrote: Show quoted text
> Thanks, but you may want to revert that. > > I just learned that metacpan is much more strict about which meta > files it > lists as compared to search.cpan.org. Apparently, it's been hiding > distros' > README.txt and LICENSE.txt all this time, whereas these were picked up > by > search.cpan.org. > > Specifically, I think metacpan only lists the following: > > ... > CONTRIBUTING.pod > INSTALL.pod > README.pod
metacpan doesn't display pod files in the root now, because those files tend to get installed into the user's PERL5LIB.
CC: IKEGAMI [...] cpan.org
MIME-Version: 1.0
X-Spam-Status: No, score=-5.362 tagged_above=-99.9 required=10 tests=[AWL=1.236, BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, FROM_OUR_RT=-4, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=ham
In-Reply-To: <rt-4.0.18-4310-1462813811-287.114247-6-0 [...] rt.cpan.org>
X-Spam-Flag: NO
X-RT-Interface: API
References: <RT-Ticket-114247 [...] rt.cpan.org> <rt-4.0.18-14464-1462764958-150.114247-6-0 [...] rt.cpan.org> <rt-4.0.18-17437-1462781051-83.114247-6-0 [...] rt.cpan.org> <CALJW-qEwLNZENyuj9A=shw=gpn1SYh2t-4YjnBvtoOy03==s6A [...] mail.gmail.com> <rt-4.0.18-9152-1462798223-831.114247-6-0 [...] rt.cpan.org> <rt-4.0.18-4310-1462813811-287.114247-6-0 [...] rt.cpan.org>
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
X-Received: by 10.182.26.5 with SMTP id h5mr1673947obg.45.1462821606799; Mon, 09 May 2016 12:20:06 -0700 (PDT)
Message-ID: <CALJW-qHzCnSOb3um_NfT=B5fbkpfj-OPtuipdrUQivOb344S1w [...] mail.gmail.com>
Content-Type: multipart/alternative; boundary="14dae93b568c3e421705326db21c"
X-Spam-Score: -5.362
Authentication-Results: hipster.bestpractical.com (amavisd-new); dkim=pass header.i= [...] gmail.com
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id C056B24039E for <cpan-bug+Module-CPANTS-Analyse [...] hipster.bestpractical.com>; Mon, 9 May 2016 15:20:19 -0400 (EDT)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KkmdD+YYcbXP for <cpan-bug+Module-CPANTS-Analyse [...] hipster.bestpractical.com>; Mon, 9 May 2016 15:20:18 -0400 (EDT)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id E6E4424038D for <bug-Module-CPANTS-Analyse [...] rt.cpan.org>; Mon, 9 May 2016 15:20:17 -0400 (EDT)
Received: (qmail 10526 invoked by alias); 9 May 2016 19:20:17 -0000
Received: from mail-ob0-f179.google.com (HELO mail-ob0-f179.google.com) (209.85.214.179) by la.mx.develooper.com (qpsmtpd/0.28) with ESMTP; Mon, 09 May 2016 12:20:14 -0700
Received: by mail-ob0-f179.google.com with SMTP id aq1so82703644obc.3 for <bug-Module-CPANTS-Analyse [...] rt.cpan.org>; Mon, 09 May 2016 12:20:14 -0700 (PDT)
Received: by 10.182.122.104 with HTTP; Mon, 9 May 2016 12:20:06 -0700 (PDT)
Delivered-To: cpan-bug+Module-CPANTS-Analyse [...] hipster.bestpractical.com
Subject: Re: [rt.cpan.org #114247] Module::CPANTS::Kwalitee::License doesn't look for LICENSE.txt
Return-Path: <ikesuke [...] gmail.com>
Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc; bh=zZzyR+3zFEEYIOLvmvppeRmdEgewAMfoz51qVBQ6jSE=; b=zs1wwb7lSqRj1IuvK1CMETZZ79awlDlXrtt5KgALuNaHh288APyhA932v2cYD6cZVD 9rCCttcH8R+qoZggtHfNwFb6lZVnsRWY5h6I/LJenl4/A6R4Axa7mlSi3qEYZe7HIKqG 8HSVryMhXEb8oLL5kVXALfz2jd+yLSrfqlRMo0dbt9d8oOS9uVWQEgEGA/x8Cr8xVF2t +HcP1gd1/c2Ue8B+6DiEqUZ4ht1y+JwzWHPcBt+Qs5PdcVZMtTxJIJ/SibNlrh8bdMyb q+2KkM+JMfLYIqIIdZKvuy240eBQ2s56ake73j2PczaYDg4Zr5CswVf5zwPWnzHjnv43 vzlw==
X-Spam-Check-BY: la.mx.develooper.com
X-Original-To: cpan-bug+Module-CPANTS-Analyse [...] hipster.bestpractical.com
X-RT-Mail-Extension: module-cpants-analyse
X-Google-Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:date :message-id:subject:from:to:cc; bh=zZzyR+3zFEEYIOLvmvppeRmdEgewAMfoz51qVBQ6jSE=; b=DMn5zBS0QqR7jBv+SL9v/AmwbrEFfHWazXrfQRjSuP9D3rpNCnMOrHrc+sEPYhknrt V78EZRN9oifyv/DP+YReYSxEDZLmbC1oxIwsKDnVMOwWFRz7NROqD1ujqma5JDJxN7OV ARWCyQUuRA5iGaBPO7uq2ieFn0lARAwQhGey2mEtDVohCTcHXVP+cxN5h1dJGAMq4X3i bWLqbaZUqgMW/UfDuv/dl9nG8zGxKU2y4BiAu6htMZ+1sCzrREgdJLw3Ee6uKPc61wjC 9T27YK3JG7MxjRFnhfkWOUeK6NYHG7q5MF4DdS+FUotJ10wp2kzDVpAAn+c/jUnNMf90 m1qg==
X-Google-Sender-Auth: uOw8YHlOWGYLcvRJmvWyeUiDGcE
Sender: ikesuke [...] gmail.com
Date: Mon, 9 May 2016 15:20:06 -0400
X-Spam-Level:
To: bug-Module-CPANTS-Analyse [...] rt.cpan.org
X-GM-Message-State: AOPr4FWE7UJGXAkFz5dxK9nGbs0TVbCrOgCg/IpFyXsECQfp2pAuSNroFmemH8grywkz4BWJFJS+g//RKxKRLw==
From: Eric Brine <ikegami [...] adaelis.com>
RT-Message-ID: <rt-4.0.18-27414-1462821620-575.114247-0-0 [...] rt.cpan.org>
Content-Length: 0
content-type: text/plain; charset="utf-8"
X-RT-Original-Encoding: utf-8
Content-Length: 925
Download (untitled) / with headers
text/plain 925b
Indeed (Example: https://metacpan.org/release/Geo-GeoNames) That list I got from metacpan's source must be for something else. On Mon, May 9, 2016 at 1:10 PM, Karen Etheridge via RT < bug-Module-CPANTS-Analyse@rt.cpan.org> wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=114247 > > > On 2016-05-09 05:50:23, ikegami@adaelis.com wrote:
> > Thanks, but you may want to revert that. > > > > I just learned that metacpan is much more strict about which meta > > files it > > lists as compared to search.cpan.org. Apparently, it's been hiding > > distros' > > README.txt and LICENSE.txt all this time, whereas these were picked up > > by > > search.cpan.org. > > > > Specifically, I think metacpan only lists the following: > > > > ... > > CONTRIBUTING.pod > > INSTALL.pod > > README.pod
> > metacpan doesn't display pod files in the root now, because those files > tend to get installed into the user's PERL5LIB. >
content-type: text/html; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
X-RT-Original-Encoding: utf-8
Content-Length: 1747


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.