Skip Menu |
 

This queue is for tickets about the PDF-API2 CPAN distribution.

Report information
The Basics
Id: 113514
Status: resolved
Priority: 0/
Queue: PDF-API2

People
Owner: Nobody in particular
Requestors: futuramedium [...] yandex.ru
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 2.027
Fixed in: 2.029



Subject: Typos in ExtGState.pm
MIME-Version: 1.0
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
Message-ID: <rt-4.0.18-5562-1459597057-1054.0-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 809
Download (untitled) / with headers
text/plain 809b
In 2.027 (and probably all the way back), line #238 should set 'D' property instead of 'ML'. Line #258 should set 'RI' instead of 'FL'. Also, the module has no strictures enabled, and if we turn them on, then it dies in line #44, because of unknown '$self'. It's unclear what this method ('new_api') is supposed to do (and if it was ever used at all because of this bug), i.e. when we should use it -- both reading code and very cryptic pod. Plus, I had to look up what on Earth is the "Halftone Phase" - it's from the Display Postscript extensions, was described in Postscript Level2 Manual, briefly mentioned in PDF 1.2 and gone without a trace in later references. I think there's no need nor support for it anymore. Rather (it goes to wishlist :) ) the 'SMask' ExtGState parameter would be implemented.
MIME-Version: 1.0
X-Spam-Status: No, score=-1.9 tagged_above=-99.9 required=10 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001] autolearn=ham
X-Spam-Flag: NO
X-RT-Interface: API
X-Cloudmark-Score: 0
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
Reply-To: phil4597 [...] catskilltech.com
Message-ID: <56FFC7AD.9080407 [...] catskilltech.com>
content-type: text/plain; charset="utf-8"; format="flowed"
Organization: Catskill Technology Services, LLC
X-RR-Connecting-Ip: 107.14.168.130:25
X-RT-Original-Encoding: utf-8
X-Spam-Score: -1.9
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id 25A9A2401D5 for <cpan-bug+PDF-API2 [...] hipster.bestpractical.com>; Sat, 2 Apr 2016 09:23:07 -0400 (EDT)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id AAxXzG9N2oHj for <cpan-bug+PDF-API2 [...] hipster.bestpractical.com>; Sat, 2 Apr 2016 09:23:04 -0400 (EDT)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id 9A8C324007F for <bug-PDF-API2 [...] rt.cpan.org>; Sat, 2 Apr 2016 09:23:04 -0400 (EDT)
Received: (qmail 21017 invoked by alias); 2 Apr 2016 13:23:03 -0000
Received: from cdptpa-outbound-snat.email.rr.com (HELO cdptpa-oedge-vip.email.rr.com) (107.14.166.226) by la.mx.develooper.com (qpsmtpd/0.28) with ESMTP; Sat, 02 Apr 2016 06:22:59 -0700
Received: from [24.161.12.73] ([24.161.12.73:1286] helo=[24.161.12.73]) by cdptpa-oedge02 (envelope-from <phil4597 [...] catskilltech.com>) (ecelerity 3.5.0.35861 r(Momo-dev:tip)) with ESMTP id DC/3B-04774-FA7CFF65; Sat, 02 Apr 2016 13:22:55 +0000
Delivered-To: cpan-bug+PDF-API2 [...] hipster.bestpractical.com
Subject: [rt.cpan.org #113514]
User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:38.0) Gecko/20100101 Thunderbird/38.7.1
Return-Path: <phil4597 [...] catskilltech.com>
X-Spam-Check-BY: la.mx.develooper.com
X-Original-To: cpan-bug+PDF-API2 [...] hipster.bestpractical.com
X-RT-Mail-Extension: pdf-api2
Date: Sat, 2 Apr 2016 09:22:53 -0400
X-Spam-Level:
To: bug-PDF-API2 [...] rt.cpan.org
Content-Transfer-Encoding: 7bit
From: Phil M Perry <phil4597 [...] catskilltech.com>
RT-Message-ID: <rt-4.0.18-19924-1459603388-1234.113514-0-0 [...] rt.cpan.org>
Content-Length: 308
Download (untitled) / with headers
text/plain 308b
Just a note that the {ML} value typo is a duplicate of bug 98552 (Extended Graphics State dash() method not working). I have not yet investigated whether it should be {D}. By all means go ahead and submit a patch. It appears that there was a lot of sloppy cut and paste in the early days of development.
MIME-Version: 1.0
In-Reply-To: <rt-4.0.18-5562-1459597057-1054.0-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <rt-4.0.18-5562-1459597057-1054.0-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.18-23215-1475873413-1088.113514-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 1322
Download (untitled) / with headers
text/plain 1.2k
On Sat Apr 02 07:37:37 2016, vadimr wrote: Show quoted text
> In 2.027 (and probably all the way back), line #238 should set 'D' > property instead of 'ML'. Line #258 should set 'RI' instead of 'FL'.
Fixed, thanks. This will be in the next release (2.029). The output of the dash() method was also incorrect, so I fixed that as well. Show quoted text
> Also, the module has no strictures enabled, and if we turn them on, > then it dies in line #44, because of unknown '$self'. It's unclear > what this method ('new_api') is supposed to do (and if it was ever > used at all because of this bug), i.e. when we should use it -- both > reading code and very cryptic pod.
You can ignore new_api. It's used internally, and will likely be removed soon. Show quoted text
> Plus, I had to look up what on Earth is the "Halftone Phase" - it's > from the Display Postscript extensions, was described in Postscript > Level2 Manual, briefly mentioned in PDF 1.2 and gone without a trace > in later references. I think there's no need nor support for it > anymore. Rather (it goes to wishlist :) ) the 'SMask' ExtGState > parameter would be implemented.
Feel free to send along a patch or a pull request that adds the SMask parameter. It doesn't look like it'll be too hard to add (you just need to check to see if the argument is a name or a dictionary, according to the spec).


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.