Skip Menu |
 

This queue is for tickets about the Encode CPAN distribution.

Report information
The Basics
Id: 111853
Status: resolved
Priority: 0/
Queue: Encode

People
Owner: Nobody in particular
Requestors: dwheeler [...] cpan.org
SREZIC [...] cpan.org
Cc: pali [...] cpan.org
AdminCc:

Bug Information
Severity: (no value)
Broken in:
  • 2.80
  • 2.81
  • 2.82
  • 2.83
Fixed in: (no value)



Subject: Encode >= 2.80 breaks HTML-DOM-0.055
MIME-Version: 1.0
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
Message-ID: <rt-4.0.18-4012-1454867450-1517.0-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 346
Download (untitled) / with headers
text/plain 346b
See https://rt.cpan.org/Ticket/Display.html?id=111824 The test failures look like this: expected: # Content-Disposition: form-data; name="foo" got: # Content-Disposition: form-data; name="=?UTF-8?B?Zm9v?=" And while the got result is not exactly wrong, I don't think that utf-8+base64 should be used here where plain ascii would also work.
MIME-Version: 1.0
In-Reply-To: <rt-4.0.18-4012-1454867450-1517.0-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <rt-4.0.18-4012-1454867450-1517.0-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.18-16926-1456257650-721.111853-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 490
Download (untitled) / with headers
text/plain 490b
On 2016-02-07 12:50:50, SREZIC wrote: Show quoted text
> See https://rt.cpan.org/Ticket/Display.html?id=111824 > > The test failures look like this: > > expected: > > # Content-Disposition: form-data; name="foo" > > got: > > # Content-Disposition: form-data; name="=?UTF-8?B?Zm9v?=" > > > And while the got result is not exactly wrong, I don't think that utf- > 8+base64 should be used here where plain ascii would also work.
Also affected (possibly): https://github.com/theory/svn-notify/issues/14
MIME-Version: 1.0
In-Reply-To: <rt-4.0.18-4012-1454867450-1517.0-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <rt-4.0.18-4012-1454867450-1517.0-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.18-31274-1458910234-1231.111853-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 392
Download (untitled) / with headers
text/plain 392b
On Ned Feb 07 12:50:50 2016, SREZIC wrote: Show quoted text
> The test failures look like this: > > expected: > > # Content-Disposition: form-data; name="foo" > > got: > > # Content-Disposition: form-data; name="=?UTF-8?B?Zm9v?="
This looks like a broken test. Name attribute in Content-Disposition header must be us-ascii, not MIME. So it looks like you try to MIME encode that attribute which is wrong.
MIME-Version: 1.0
In-Reply-To: <rt-4.0.18-31274-1458910234-1231.111853-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <rt-4.0.18-4012-1454867450-1517.0-0-0 [...] rt.cpan.org> <rt-4.0.18-31274-1458910234-1231.111853-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.18-6065-1458946373-734.111853-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 626
Download (untitled) / with headers
text/plain 626b
On 2016-03-25 08:50:34, PALI wrote: Show quoted text
> This looks like a broken test. Name attribute in Content-Disposition > header must be us-ascii, not MIME. So it looks like you try to MIME > encode that attribute which is wrong.
Well, the SVN::Notify test failure referenced by SREZIC is: # Subject: =?UTF-8?Q?=5B111=5D_Did_this,_that,_and_the_=C2=ABother=C2=BB.?=' # # doesn't match '(?^:Subject: \[111\] \=\?UTF\-8\?Q\?Did_this\,_that\,_and_the_\=C2\=ABother\=C2\=BB\.\?\=\n)' Here's where it uses Encode to MIME-Q encode the subject and other headers: https://github.com/theory/svn-notify/blob/master/lib/SVN/Notify.pm#L1464
MIME-Version: 1.0
In-Reply-To: <rt-4.0.18-6065-1458946373-734.111853-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <rt-4.0.18-4012-1454867450-1517.0-0-0 [...] rt.cpan.org> <rt-4.0.18-31274-1458910234-1231.111853-0-0 [...] rt.cpan.org> <rt-4.0.18-6065-1458946373-734.111853-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.18-32467-1459126806-680.111853-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 955
Download (untitled) / with headers
text/plain 955b
On Pia mar 25 18:52:53 2016, DWHEELER wrote: Show quoted text
> On 2016-03-25 08:50:34, PALI wrote: >
> > This looks like a broken test. Name attribute in Content-Disposition > > header must be us-ascii, not MIME. So it looks like you try to MIME > > encode that attribute which is wrong.
> > Well, the SVN::Notify test failure referenced by SREZIC is: > > # Subject: =?UTF- > 8?Q?=5B111=5D_Did_this,_that,_and_the_=C2=ABother=C2=BB.?=' > # > # doesn't match '(?^:Subject: \[111\] \=\?UTF\- > 8\?Q\?Did_this\,_that\,_and_the_\=C2\=ABother\=C2\=BB\.\?\=\n)'
This looks correct.. or where do you see problem? Show quoted text
> Here's where it uses Encode to MIME-Q encode the subject and other > headers: > > https://github.com/theory/svn- > notify/blob/master/lib/SVN/Notify.pm#L1464
Looks like that test try to encode whole "from" and "to" headers. That would produce incorrect email. Only phrase part(s) of "from" and "to" headers must be MIME encoded -- not email address itself.
CC: SREZIC [...] cpan.org, pali [...] cpan.org
MIME-Version: 1.0 (Mac OS X Mail 9.3 \(3124\))
X-Spam-Status: No, score=-5.487 tagged_above=-99.9 required=10 tests=[AWL=1.113, BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FROM_OUR_RT=-4, RCVD_IN_DNSWL_LOW=-0.7] autolearn=ham
In-Reply-To: <rt-4.0.18-32467-1459126806-447.111853-6-0 [...] rt.cpan.org>
X-Mailer: Apple Mail (2.3124)
X-Spam-Flag: NO
X-RT-Interface: API
References: <RT-Ticket-111853 [...] rt.cpan.org> <rt-4.0.18-4012-1454867450-1517.111853-6-0 [...] rt.cpan.org> <rt-4.0.18-31274-1458910234-1231.111853-6-0 [...] rt.cpan.org> <rt-4.0.18-6065-1458946373-734.111853-6-0 [...] rt.cpan.org> <rt-4.0.18-32467-1459126806-447.111853-6-0 [...] rt.cpan.org>
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
content-type: text/plain; charset="utf-8"
Message-ID: <8DFFA6AA-8DCA-4D3C-807F-9B9BCE53C710 [...] cpan.org>
X-RT-Original-Encoding: utf-8
X-Spam-Score: -5.487
Authentication-Results: hipster.bestpractical.com (amavisd-new); dkim=pass header.i= [...] pobox.com
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id DF39F240332 for <cpan-bug+Encode [...] hipster.bestpractical.com>; Mon, 28 Mar 2016 13:33:04 -0400 (EDT)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KHakLSRS0268 for <cpan-bug+Encode [...] hipster.bestpractical.com>; Mon, 28 Mar 2016 13:33:03 -0400 (EDT)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id 3AACF2402C4 for <bug-Encode [...] rt.cpan.org>; Mon, 28 Mar 2016 13:33:02 -0400 (EDT)
Received: (qmail 13547 invoked by alias); 28 Mar 2016 17:33:00 -0000
Received: from pb-smtp0.pobox.com (HELO sasl.smtp.pobox.com) (208.72.237.35) by la.mx.develooper.com (qpsmtpd/0.28) with ESMTP; Mon, 28 Mar 2016 10:32:58 -0700
Received: from sasl.smtp.pobox.com (unknown [127.0.0.1]) by pb-smtp0.pobox.com (Postfix) with ESMTP id 398D84FEA7; Mon, 28 Mar 2016 13:32:55 -0400 (EDT)
Received: from pb-smtp0.int.icgroup.com (unknown [127.0.0.1]) by pb-smtp0.pobox.com (Postfix) with ESMTP id 3134C4FEA6; Mon, 28 Mar 2016 13:32:55 -0400 (EDT)
Received: from dwhee-ma-2944.iovation.com (unknown [74.121.28.6]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by pb-smtp0.pobox.com (Postfix) with ESMTPSA id 6D6D64FEA0; Mon, 28 Mar 2016 13:32:54 -0400 (EDT)
Delivered-To: cpan-bug+Encode [...] hipster.bestpractical.com
Subject: Re: [rt.cpan.org #111853] Encode >= 2.80 breaks HTML-DOM-0.055
Return-Path: <dwheeler [...] cpan.org>
Dkim-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=content-type :mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; s=sasl; bh= r5LGv6jbZeygWQ91u/Rte1rFULU=; b=QjYFf93IYZNYQsQMu+xORKIyYwQJ2AWD tHNWXhWHg7I0GDizJnugPY3Z6g2vmwt4r5gP3OxB5BZS7HJEjOH6qqvNV/9GtUuO rnxwcd+IBmzn10lYegLQlC7ebMhPwN8kc0JtifJY/eB6Jo9MYauoM6X7vUAsCrhO CWy4joJAC5A=
X-Spam-Check-BY: la.mx.develooper.com
X-Original-To: cpan-bug+Encode [...] hipster.bestpractical.com
X-RT-Mail-Extension: encode
Date: Mon, 28 Mar 2016 10:32:58 -0700
X-Spam-Level:
To: bug-Encode [...] rt.cpan.org
Content-Transfer-Encoding: quoted-printable
X-Pobox-Relay-ID: 1AC29EBA-F50B-11E5-B8C0-E95C6BB36C07-76319746!pb-smtp0.pobox.com
From: "David E. Wheeler" <dwheeler [...] cpan.org>
RT-Message-ID: <rt-4.0.18-20777-1459186385-948.111853-0-0 [...] rt.cpan.org>
Content-Length: 670
Download (untitled) / with headers
text/plain 670b
On Mar 27, 2016, at 6:00 PM, Pali via RT <bug-Encode@rt.cpan.org> wrote: Show quoted text
> This looks correct.. or where do you see problem?
The test passed for like 8 years and suddenly started failing. Did something change in the MIME-Q encoder? Only change I see matching “MIME-Q" in Changes dates from 2009. I can probably change the test to use encode instead of its own regex. It’s just odd that it started breaking after all these years. Show quoted text
> Looks like that test try to encode whole "from" and "to" headers. That would produce incorrect email. Only phrase part(s) of "from" and "to" headers must be MIME encoded -- not email address itself.
Good to know, thanks. David
CC: bug-Encode [...] rt.cpan.org, SREZIC [...] cpan.org
MIME-Version: 1.0
X-Spam-Status: No, score=-8.2 tagged_above=-99.9 required=10 tests=[BAYES_00=-1.9, FROM_OUR_RT=-4, RCVD_IN_DNSWL_MED=-2.3] autolearn=ham
In-Reply-To: <8DFFA6AA-8DCA-4D3C-807F-9B9BCE53C710 [...] cpan.org>
X-Spam-Flag: NO
X-RT-Interface: API
References: <RT-Ticket-111853 [...] rt.cpan.org> <rt-4.0.18-32467-1459126806-447.111853-6-0 [...] rt.cpan.org> <8DFFA6AA-8DCA-4D3C-807F-9B9BCE53C710 [...] cpan.org>
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
content-type: Text/Plain; charset="utf-8"
Message-ID: <201603281940.42398 [...] pali>
X-RT-Original-Encoding: utf-8
X-Spam-Score: -8.2
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id A02B3240332 for <cpan-bug+Encode [...] hipster.bestpractical.com>; Mon, 28 Mar 2016 13:41:06 -0400 (EDT)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id IAfp+lTUMQQ3 for <cpan-bug+Encode [...] hipster.bestpractical.com>; Mon, 28 Mar 2016 13:41:05 -0400 (EDT)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id A21812402C4 for <bug-Encode [...] rt.cpan.org>; Mon, 28 Mar 2016 13:41:04 -0400 (EDT)
Received: (qmail 14017 invoked by alias); 28 Mar 2016 17:41:03 -0000
Received: from smtp1.kolej.mff.cuni.cz (HELO smtp1.kolej.mff.cuni.cz) (78.128.192.10) by la.mx.develooper.com (qpsmtpd/0.28) with ESMTP; Mon, 28 Mar 2016 10:40:56 -0700
Received: from pali-latitude.localnet (pali.kolej.mff.cuni.cz [78.128.193.202]) by smtp1.kolej.mff.cuni.cz (8.15.2/8.15.2) with ESMTP id u2SHegGT054720; Mon, 28 Mar 2016 19:40:43 +0200 (CEST) (envelope-from pali [...] cpan.org)
Delivered-To: cpan-bug+Encode [...] hipster.bestpractical.com
Subject: Re: [rt.cpan.org #111853] Encode >= 2.80 breaks HTML-DOM-0.055
User-Agent: KMail/1.13.7 (Linux/3.13.0-83-generic; KDE/4.14.2; x86_64; ; )
Return-Path: <pali [...] cpan.org>
X-Envelope-From: pali [...] cpan.org
X-Spam-Check-BY: la.mx.develooper.com
X-Original-To: cpan-bug+Encode [...] hipster.bestpractical.com
X-RT-Mail-Extension: encode
Date: Mon, 28 Mar 2016 19:40:37 +0200
X-Spam-Level:
To: "David E. Wheeler" <dwheeler [...] cpan.org>
Content-Transfer-Encoding: 8bit
From: pali [...] cpan.org
RT-Message-ID: <rt-4.0.18-23048-1459186867-652.111853-0-0 [...] rt.cpan.org>
Content-Length: 956
Download (untitled) / with headers
text/plain 956b
On Monday 28 March 2016 19:32:58 David E. Wheeler wrote: Show quoted text
> On Mar 27, 2016, at 6:00 PM, Pali via RT <bug-Encode@rt.cpan.org> wrote:
> > This looks correct.. or where do you see problem?
> > The test passed for like 8 years and suddenly started failing. Did > something change in the MIME-Q encoder? Only change I see matching > “MIME-Q" in Changes dates from 2009.
Yes, finally after years in Encode version 2.83 I fixed Encode::MIME::Header package to correctly encode and decode strings... Show quoted text
> I can probably change the test to use encode instead of its own > regex. It’s just odd that it started breaking after all these years.
Beware that parsing some of email headers is not easy by regexes... Show quoted text
> > Looks like that test try to encode whole "from" and "to" headers. > > That would produce incorrect email. Only phrase part(s) of "from" > > and "to" headers must be MIME encoded -- not email address itself.
> > Good to know, thanks. > > David
CC: SREZIC [...] cpan.org, pali [...] cpan.org
MIME-Version: 1.0 (Mac OS X Mail 9.3 \(3124\))
X-Spam-Status: No, score=-5.527 tagged_above=-99.9 required=10 tests=[AWL=1.073, BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FROM_OUR_RT=-4, RCVD_IN_DNSWL_LOW=-0.7] autolearn=ham
In-Reply-To: <rt-4.0.18-23048-1459186867-1720.111853-6-0 [...] rt.cpan.org>
X-Mailer: Apple Mail (2.3124)
X-Spam-Flag: NO
X-RT-Interface: API
References: <RT-Ticket-111853 [...] rt.cpan.org> <rt-4.0.18-32467-1459126806-447.111853-6-0 [...] rt.cpan.org> <8DFFA6AA-8DCA-4D3C-807F-9B9BCE53C710 [...] cpan.org> <201603281940.42398 [...] pali> <rt-4.0.18-23048-1459186867-1720.111853-6-0 [...] rt.cpan.org>
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
content-type: text/plain; charset="utf-8"
Message-ID: <8762CB3C-5D87-4C72-BB99-68B4B5860444 [...] cpan.org>
X-RT-Original-Encoding: utf-8
X-Spam-Score: -5.527
Authentication-Results: hipster.bestpractical.com (amavisd-new); dkim=pass header.i= [...] pobox.com
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id 42C1C240332 for <cpan-bug+Encode [...] hipster.bestpractical.com>; Mon, 28 Mar 2016 13:42:49 -0400 (EDT)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id C8b7S0rXf3WR for <cpan-bug+Encode [...] hipster.bestpractical.com>; Mon, 28 Mar 2016 13:42:48 -0400 (EDT)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id C8BED2402C4 for <bug-Encode [...] rt.cpan.org>; Mon, 28 Mar 2016 13:42:47 -0400 (EDT)
Received: (qmail 14105 invoked by alias); 28 Mar 2016 17:42:47 -0000
Received: from pb-smtp0.pobox.com (HELO sasl.smtp.pobox.com) (208.72.237.35) by la.mx.develooper.com (qpsmtpd/0.28) with ESMTP; Mon, 28 Mar 2016 10:42:45 -0700
Received: from sasl.smtp.pobox.com (unknown [127.0.0.1]) by pb-smtp0.pobox.com (Postfix) with ESMTP id 03D794D1BC; Mon, 28 Mar 2016 13:42:42 -0400 (EDT)
Received: from pb-smtp0.int.icgroup.com (unknown [127.0.0.1]) by pb-smtp0.pobox.com (Postfix) with ESMTP id EF6B14D1BB; Mon, 28 Mar 2016 13:42:41 -0400 (EDT)
Received: from dwhee-ma-2944.iovation.com (unknown [74.121.28.6]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by pb-smtp0.pobox.com (Postfix) with ESMTPSA id 4ABE94D1B8; Mon, 28 Mar 2016 13:42:41 -0400 (EDT)
Delivered-To: cpan-bug+Encode [...] hipster.bestpractical.com
Subject: Re: [rt.cpan.org #111853] Encode >= 2.80 breaks HTML-DOM-0.055
Return-Path: <dwheeler [...] cpan.org>
Dkim-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=content-type :mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; s=sasl; bh= qaAIpV8K/lxlAO3DmLtQY1aqwIw=; b=EfqyKNag43fQsH/dVFwLBbFI5o8qAbhf D7npGCli2kosP44rYbyWEkl4tqTlNx31wEHd0Q/SgOCm6OePX14BBj3qZRL6j11w hjhyS03OCBDUGVQIIAHnWwOPTSQ6c8AU1JqVcbvfXRbjUh4tbavNheGSG73RLE6I C3Tp1CtOYFo=
X-Spam-Check-BY: la.mx.develooper.com
X-Original-To: cpan-bug+Encode [...] hipster.bestpractical.com
X-RT-Mail-Extension: encode
Date: Mon, 28 Mar 2016 10:42:45 -0700
X-Spam-Level:
To: bug-Encode [...] rt.cpan.org
Content-Transfer-Encoding: quoted-printable
X-Pobox-Relay-ID: 788E0FA6-F50C-11E5-B21A-E95C6BB36C07-76319746!pb-smtp0.pobox.com
From: "David E. Wheeler" <dwheeler [...] cpan.org>
RT-Message-ID: <rt-4.0.18-27110-1459186970-1371.111853-0-0 [...] rt.cpan.org>
Content-Length: 625
Download (untitled) / with headers
text/plain 625b
On Mar 28, 2016, at 10:41 AM, Pali via RT <bug-Encode@rt.cpan.org> wrote: Show quoted text
> Yes, finally after years in Encode version 2.83 I fixed > Encode::MIME::Header package to correctly encode and decode strings...
Actually, it already does that. The test sets up the subject like this: my $subj = "Did this, that, and the «other»."; my $qsubj; if (SVN::Notify::PERL58()) { $subj = Encode::decode_utf8( $subj ); $qsubj = quotemeta Encode::encode( 'MIME-Q', $subj ); } else { $qsubj = quotemeta $subj; } So I don’t understand why the test fails. Both the test and the code Q-encode the UTF-8 subject. Best, David
CC: bug-Encode [...] rt.cpan.org, SREZIC [...] cpan.org
MIME-Version: 1.0
X-Spam-Status: No, score=-8.2 tagged_above=-99.9 required=10 tests=[BAYES_00=-1.9, FROM_OUR_RT=-4, RCVD_IN_DNSWL_MED=-2.3] autolearn=ham
In-Reply-To: <8762CB3C-5D87-4C72-BB99-68B4B5860444 [...] cpan.org>
X-Spam-Flag: NO
X-RT-Interface: API
References: <RT-Ticket-111853 [...] rt.cpan.org> <rt-4.0.18-23048-1459186867-1720.111853-6-0 [...] rt.cpan.org> <8762CB3C-5D87-4C72-BB99-68B4B5860444 [...] cpan.org>
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
content-type: Text/Plain; charset="utf-8"
Message-ID: <201603281951.11911 [...] pali>
X-RT-Original-Encoding: utf-8
X-Spam-Score: -8.2
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id D4489240332 for <cpan-bug+Encode [...] hipster.bestpractical.com>; Mon, 28 Mar 2016 13:51:23 -0400 (EDT)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id m1jxyidBP3aC for <cpan-bug+Encode [...] hipster.bestpractical.com>; Mon, 28 Mar 2016 13:51:22 -0400 (EDT)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id 6B1D72402C4 for <bug-Encode [...] rt.cpan.org>; Mon, 28 Mar 2016 13:51:22 -0400 (EDT)
Received: (qmail 14628 invoked by alias); 28 Mar 2016 17:51:21 -0000
Received: from smtp1.kolej.mff.cuni.cz (HELO smtp1.kolej.mff.cuni.cz) (78.128.192.10) by la.mx.develooper.com (qpsmtpd/0.28) with ESMTP; Mon, 28 Mar 2016 10:51:20 -0700
Received: from pali-latitude.localnet (pali.kolej.mff.cuni.cz [78.128.193.202]) by smtp1.kolej.mff.cuni.cz (8.15.2/8.15.2) with ESMTP id u2SHpCaf054829; Mon, 28 Mar 2016 19:51:13 +0200 (CEST) (envelope-from pali [...] cpan.org)
Delivered-To: cpan-bug+Encode [...] hipster.bestpractical.com
Subject: Re: [rt.cpan.org #111853] Encode >= 2.80 breaks HTML-DOM-0.055
User-Agent: KMail/1.13.7 (Linux/3.13.0-83-generic; KDE/4.14.2; x86_64; ; )
Return-Path: <pali [...] cpan.org>
X-Envelope-From: pali [...] cpan.org
X-Spam-Check-BY: la.mx.develooper.com
X-Original-To: cpan-bug+Encode [...] hipster.bestpractical.com
X-RT-Mail-Extension: encode
Date: Mon, 28 Mar 2016 19:51:02 +0200
X-Spam-Level:
To: "David E. Wheeler" <dwheeler [...] cpan.org>
Content-Transfer-Encoding: 8bit
From: pali [...] cpan.org
RT-Message-ID: <rt-4.0.18-29648-1459187484-555.111853-0-0 [...] rt.cpan.org>
Content-Length: 762
Download (untitled) / with headers
text/plain 762b
On Monday 28 March 2016 19:42:45 David E. Wheeler wrote: Show quoted text
> On Mar 28, 2016, at 10:41 AM, Pali via RT <bug-Encode@rt.cpan.org> wrote:
> > Yes, finally after years in Encode version 2.83 I fixed > > Encode::MIME::Header package to correctly encode and decode > > strings...
> > Actually, it already does that. The test sets up the subject like > this: > > my $subj = "Did this, that, and the «other»."; > my $qsubj; > if (SVN::Notify::PERL58()) { > $subj = Encode::decode_utf8( $subj ); > $qsubj = quotemeta Encode::encode( 'MIME-Q', $subj ); > } else { > $qsubj = quotemeta $subj; > } > > So I don’t understand why the test fails. Both the test and the code > Q-encode the UTF-8 subject. > > Best, > > David
And what does that test compare?
CC: SREZIC [...] cpan.org
MIME-Version: 1.0 (Mac OS X Mail 9.3 \(3124\))
X-Spam-Status: No, score=-5.564 tagged_above=-99.9 required=10 tests=[AWL=1.036, BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FROM_OUR_RT=-4, RCVD_IN_DNSWL_LOW=-0.7] autolearn=ham
In-Reply-To: <rt-4.0.18-29648-1459187484-816.111853-6-0 [...] rt.cpan.org>
X-Mailer: Apple Mail (2.3124)
X-Spam-Flag: NO
X-RT-Interface: API
References: <RT-Ticket-111853 [...] rt.cpan.org> <rt-4.0.18-23048-1459186867-1720.111853-6-0 [...] rt.cpan.org> <8762CB3C-5D87-4C72-BB99-68B4B5860444 [...] cpan.org> <201603281951.11911 [...] pali> <rt-4.0.18-29648-1459187484-816.111853-6-0 [...] rt.cpan.org>
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
content-type: text/plain; charset="utf-8"
Message-ID: <7287CE78-5952-446D-9BB9-346422CAE8FC [...] cpan.org>
X-RT-Original-Encoding: utf-8
X-Spam-Score: -5.564
Authentication-Results: hipster.bestpractical.com (amavisd-new); dkim=pass header.i= [...] pobox.com
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id 7674A2403D1 for <cpan-bug+Encode [...] hipster.bestpractical.com>; Mon, 28 Mar 2016 13:54:04 -0400 (EDT)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XRF1Mrme-0qh for <cpan-bug+Encode [...] hipster.bestpractical.com>; Mon, 28 Mar 2016 13:54:03 -0400 (EDT)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id EF7C5240332 for <bug-Encode [...] rt.cpan.org>; Mon, 28 Mar 2016 13:54:02 -0400 (EDT)
Received: (qmail 14812 invoked by alias); 28 Mar 2016 17:54:02 -0000
Received: from pb-smtp0.pobox.com (HELO sasl.smtp.pobox.com) (208.72.237.35) by la.mx.develooper.com (qpsmtpd/0.28) with ESMTP; Mon, 28 Mar 2016 10:53:56 -0700
Received: from sasl.smtp.pobox.com (unknown [127.0.0.1]) by pb-smtp0.pobox.com (Postfix) with ESMTP id 405AB4D4AC; Mon, 28 Mar 2016 13:53:53 -0400 (EDT)
Received: from pb-smtp0.int.icgroup.com (unknown [127.0.0.1]) by pb-smtp0.pobox.com (Postfix) with ESMTP id 3814C4D4AB; Mon, 28 Mar 2016 13:53:53 -0400 (EDT)
Received: from dwhee-ma-2944.iovation.com (unknown [74.121.28.6]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by pb-smtp0.pobox.com (Postfix) with ESMTPSA id A05664D4A0; Mon, 28 Mar 2016 13:53:52 -0400 (EDT)
Delivered-To: cpan-bug+Encode [...] hipster.bestpractical.com
Subject: Re: [rt.cpan.org #111853] Encode >= 2.80 breaks HTML-DOM-0.055
Return-Path: <dwheeler [...] cpan.org>
Dkim-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=content-type :mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; s=sasl; bh= yeOQC1Ek1ixjhMFm9gtn49skQLY=; b=VW5jha7x6X5Om6gPlNqz6iYXLWHYoSWi f85BSYGhnVCgQn2o5CvQjKYgbjEbT+uO5Gy7eifuA0DUBAx0004vrChx77VeVj7o bI1o5poXZx7VES87DYph7MIr3y/xfNkIJsAOcb5csZ9vY5Av2czepuruVi0omRjZ AF1D++efw6A=
X-Spam-Check-BY: la.mx.develooper.com
X-Original-To: cpan-bug+Encode [...] hipster.bestpractical.com
X-RT-Mail-Extension: encode
Date: Mon, 28 Mar 2016 10:53:57 -0700
X-Spam-Level:
To: bug-Encode [...] rt.cpan.org
Content-Transfer-Encoding: 7bit
X-Pobox-Relay-ID: 08A93376-F50E-11E5-BCBC-E95C6BB36C07-76319746!pb-smtp0.pobox.com
From: "David E. Wheeler" <dwheeler [...] cpan.org>
RT-Message-ID: <rt-4.0.18-29648-1459187645-237.111853-0-0 [...] rt.cpan.org>
Content-Length: 207
Download (untitled) / with headers
text/plain 207b
On Mar 28, 2016, at 10:51 AM, Pali via RT <bug-Encode@rt.cpan.org> wrote: Show quoted text
> And what does that test compare?
The failing test: like( $email, qr/Subject: \[111\] $qsubj\n/, "Check subject" ); David
MIME-Version: 1.0
In-Reply-To: <rt-4.0.18-29648-1459187645-237.111853-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <RT-Ticket-111853 [...] rt.cpan.org> <rt-4.0.18-23048-1459186867-1720.111853-6-0 [...] rt.cpan.org> <8762CB3C-5D87-4C72-BB99-68B4B5860444 [...] cpan.org> <201603281951.11911 [...] pali> <rt-4.0.18-29648-1459187484-816.111853-6-0 [...] rt.cpan.org> <7287CE78-5952-446D-9BB9-346422CAE8FC [...] cpan.org> <rt-4.0.18-29648-1459187645-237.111853-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.18-16079-1459240924-942.111853-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
RT-Send-CC: pali [...] cpan.org
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 348
Download (untitled) / with headers
text/plain 348b
On Mon Mar 28 13:54:05 2016, DWHEELER wrote: Show quoted text
> On Mar 28, 2016, at 10:51 AM, Pali via RT <bug-Encode@rt.cpan.org> wrote: >
> > And what does that test compare?
> > The failing test: > > like( $email, qr/Subject: \[111\] $qsubj\n/, "Check subject" ); > > David > >
Hi! Ideally post me whole test as I still do not see what there happen...
CC: SREZIC [...] cpan.org
MIME-Version: 1.0 (Mac OS X Mail 9.3 \(3124\))
X-Spam-Status: No, score=-5.598 tagged_above=-99.9 required=10 tests=[AWL=1.002, BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FROM_OUR_RT=-4, RCVD_IN_DNSWL_LOW=-0.7] autolearn=ham
In-Reply-To: <rt-4.0.18-16079-1459240925-838.111853-6-0 [...] rt.cpan.org>
X-Mailer: Apple Mail (2.3124)
X-Spam-Flag: NO
X-RT-Interface: API
References: <RT-Ticket-111853 [...] rt.cpan.org> <rt-4.0.18-23048-1459186867-1720.111853-6-0 [...] rt.cpan.org> <8762CB3C-5D87-4C72-BB99-68B4B5860444 [...] cpan.org> <201603281951.11911 [...] pali> <rt-4.0.18-29648-1459187484-816.111853-6-0 [...] rt.cpan.org> <7287CE78-5952-446D-9BB9-346422CAE8FC [...] cpan.org> <rt-4.0.18-29648-1459187645-237.111853-6-0 [...] rt.cpan.org> <rt-4.0.18-16079-1459240925-838.111853-6-0 [...] rt.cpan.org>
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
content-type: text/plain; charset="utf-8"
Message-ID: <662ACC15-3169-450E-941E-E3FBAFA06D60 [...] cpan.org>
X-RT-Original-Encoding: utf-8
X-Spam-Score: -5.598
Authentication-Results: hipster.bestpractical.com (amavisd-new); dkim=pass header.i= [...] pobox.com
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id 3FE642403DE for <cpan-bug+Encode [...] hipster.bestpractical.com>; Tue, 29 Mar 2016 12:29:01 -0400 (EDT)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gUxx06Yh+b-o for <cpan-bug+Encode [...] hipster.bestpractical.com>; Tue, 29 Mar 2016 12:28:59 -0400 (EDT)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id 8E92E24038B for <bug-Encode [...] rt.cpan.org>; Tue, 29 Mar 2016 12:28:59 -0400 (EDT)
Received: (qmail 24338 invoked by alias); 29 Mar 2016 16:28:58 -0000
Received: from pb-smtp0.pobox.com (HELO sasl.smtp.pobox.com) (208.72.237.35) by la.mx.develooper.com (qpsmtpd/0.28) with ESMTP; Tue, 29 Mar 2016 09:28:56 -0700
Received: from sasl.smtp.pobox.com (unknown [127.0.0.1]) by pb-smtp0.pobox.com (Postfix) with ESMTP id D8A55498BC; Tue, 29 Mar 2016 12:28:52 -0400 (EDT)
Received: from pb-smtp0.int.icgroup.com (unknown [127.0.0.1]) by pb-smtp0.pobox.com (Postfix) with ESMTP id CE754498BB; Tue, 29 Mar 2016 12:28:52 -0400 (EDT)
Received: from dwhee-ma-2944.iovation.com (unknown [74.121.28.6]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by pb-smtp0.pobox.com (Postfix) with ESMTPSA id 2B29C498BA; Tue, 29 Mar 2016 12:28:52 -0400 (EDT)
Delivered-To: cpan-bug+Encode [...] hipster.bestpractical.com
Subject: Re: [rt.cpan.org #111853] Encode >= 2.80 breaks HTML-DOM-0.055
Return-Path: <dwheeler [...] cpan.org>
Dkim-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=content-type :mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; s=sasl; bh= /6c8EDzUoH6B6Ddy06YpoD8UJUg=; b=u6DHT9co/Yr5ZN++qTsOj4au3NnZJRy5 LFGKvxP04EZ2vLjYGtbLkoFJ2VKn2i6ua6Rc3O/IvB2tmLFVcYStLuLdD1BoJTl6 QoorqYzFr9BshN0NNU8y3w5A2FEjsZasyia80vEIxsbFoj3e7EjImPTrU/ZDC17V QsAsS2FHIuk=
X-Spam-Check-BY: la.mx.develooper.com
X-Original-To: cpan-bug+Encode [...] hipster.bestpractical.com
X-RT-Mail-Extension: encode
Date: Tue, 29 Mar 2016 09:28:50 -0700
X-Spam-Level:
To: bug-Encode [...] rt.cpan.org
Content-Transfer-Encoding: 7bit
X-Pobox-Relay-ID: 52F402F4-F5CB-11E5-AE23-45AF6BB36C07-76319746!pb-smtp0.pobox.com
From: "David E. Wheeler" <dwheeler [...] cpan.org>
RT-Message-ID: <rt-4.0.18-19657-1459268942-1193.111853-0-0 [...] rt.cpan.org>
Content-Length: 291
Download (untitled) / with headers
text/plain 291b
On Mar 29, 2016, at 1:42 AM, Pali via RT <bug-Encode@rt.cpan.org> wrote: Show quoted text
> Hi! Ideally post me whole test as I still do not see what there happen...
Probably easiest just to clone and run: git clone https://github.com/theory/svn-notify.git cd svn-notify prove -lv t/base.t Best, David
MIME-Version: 1.0
In-Reply-To: <rt-4.0.18-19657-1459268942-1193.111853-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <RT-Ticket-111853 [...] rt.cpan.org> <rt-4.0.18-23048-1459186867-1720.111853-6-0 [...] rt.cpan.org> <8762CB3C-5D87-4C72-BB99-68B4B5860444 [...] cpan.org> <201603281951.11911 [...] pali> <rt-4.0.18-29648-1459187484-816.111853-6-0 [...] rt.cpan.org> <7287CE78-5952-446D-9BB9-346422CAE8FC [...] cpan.org> <rt-4.0.18-29648-1459187645-237.111853-6-0 [...] rt.cpan.org> <rt-4.0.18-16079-1459240925-838.111853-6-0 [...] rt.cpan.org> <662ACC15-3169-450E-941E-E3FBAFA06D60 [...] cpan.org> <rt-4.0.18-19657-1459268942-1193.111853-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.18-23077-1459275443-186.111853-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 426
Download (untitled) / with headers
text/plain 426b
On Uto mar 29 12:29:02 2016, DWHEELER wrote: Show quoted text
> On Mar 29, 2016, at 1:42 AM, Pali via RT <bug-Encode@rt.cpan.org> wrote: >
> > Hi! Ideally post me whole test as I still do not see what there happen...
> > Probably easiest just to clone and run: > > git clone https://github.com/theory/svn-notify.git > cd svn-notify > prove -lv t/base.t > > Best, > > David >
This this patch: https://github.com/theory/svn-notify/pull/15
MIME-Version: 1.0
In-Reply-To: <rt-4.0.18-16926-1456257650-721.111853-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <rt-4.0.18-4012-1454867450-1517.0-0-0 [...] rt.cpan.org> <rt-4.0.18-16926-1456257650-721.111853-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.18-17241-1459537645-821.111853-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 152
Download (untitled) / with headers
text/plain 152b
So problem was in svn-notify (now fixed), not in Encode::MIME::Header. And I bet same would be also for HTML-DOM-0.055: incorrect usage of MIME-Header.
MIME-Version: 1.0
In-Reply-To: <rt-4.0.18-17241-1459537645-821.111853-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <rt-4.0.18-4012-1454867450-1517.0-0-0 [...] rt.cpan.org> <rt-4.0.18-16926-1456257650-721.111853-0-0 [...] rt.cpan.org> <rt-4.0.18-17241-1459537645-821.111853-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.18-774-1466849051-155.111853-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 55
Bug for HTML-DOM is now closed, so close also this one.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.