Skip Menu |
 

This queue is for tickets about the Perl-Dist-Strawberry CPAN distribution.

Report information
The Basics
Id: 107316
Status: open
Priority: 0/
Queue: Perl-Dist-Strawberry

People
Owner: Nobody in particular
Requestors: ether [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: uses File::Slurp
MIME-Version: 1.0
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
Message-ID: <rt-4.0.18-20555-1443135350-875.0-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 131
Download (untitled) / with headers
text/plain 131b
MIME-Version: 1.0
In-Reply-To: <rt-4.0.18-20555-1443135350-875.0-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <rt-4.0.18-20555-1443135350-875.0-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.18-27866-1443148433-365.107316-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 363
Download (untitled) / with headers
text/plain 363b
On Thu Sep 24 18:55:50 2015, ETHER wrote: Show quoted text
> Here is one summary of the issues involved: > http://blogs.perl.org/users/leon_timmermans/2015/08/fileslurp-is- > broken-and-wrong.html
We're not encountering the issues - File::Slurp works just fine for what this distribution uses it for. There's no immediate need to change. Now if it improved build speed as well...
MIME-Version: 1.0
In-Reply-To: <rt-4.0.18-27866-1443148433-365.107316-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <rt-4.0.18-20555-1443135350-875.0-0-0 [...] rt.cpan.org> <rt-4.0.18-27866-1443148433-365.107316-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.18-623-1443159629-1861.107316-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 1141
Download (untitled) / with headers
text/plain 1.1k
On Thu Sep 24 22:33:53 2015, CSJEWELL wrote: Show quoted text
> On Thu Sep 24 18:55:50 2015, ETHER wrote:
> > Here is one summary of the issues involved: > > http://blogs.perl.org/users/leon_timmermans/2015/08/fileslurp-is- > > broken-and-wrong.html
> > We're not encountering the issues - File::Slurp works just fine for > what this distribution uses it for. There's no immediate need to > change. Now if it improved build speed as well...
Sure, but your use of it to build Strawberry is read as an implicit endorsement of the broken thing. Trying to get everybody to use sane, best practice distributions is what's driven my previous evangelism of Strawberry Perl to other people and why I'm proud that the Enlightened Perl Organisation is helping defray your hosting costs. From the point of view of building Strawberry itself, perhaps it isn't a bug yet. From the point of view of enabling win32 perl users to get access to CPAN and to take advantage of the best of CPAN, it definitely *is* a bug. I mean, you could make the same argument about code that doesn't 'use strict;' and I'd tend to think that should be fixed up too if at all possible :)
MIME-Version: 1.0
In-Reply-To: <rt-4.0.18-20555-1443135350-875.0-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <rt-4.0.18-20555-1443135350-875.0-0-0 [...] rt.cpan.org>
Content-Type: text/html; charset="utf-8"
Message-ID: <rt-4.0.18-32073-1443159857-985.107316-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 269
ether,

it would have been fine if you had check our bug queue before submitting duplicate bug report.

See https://rt.cpan.org/Public/Bug/Display.html?id=95482

And guess what? The #95482 is yours :)

--
kmx
MIME-Version: 1.0
In-Reply-To: <rt-4.0.18-623-1443159629-1861.107316-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <rt-4.0.18-20555-1443135350-875.0-0-0 [...] rt.cpan.org> <rt-4.0.18-27866-1443148433-365.107316-0-0 [...] rt.cpan.org> <rt-4.0.18-623-1443159629-1861.107316-0-0 [...] rt.cpan.org>
Content-Type: text/html; charset="utf-8"
Message-ID: <rt-4.0.18-28725-1443166204-713.107316-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 1278
Matt,

I see your point, it's basically the same as a year ago - https://rt.cpan.org/Public/Bug/Display.html?id=95482

OK, in 2014 you (or ether?) were recommending File::Slurp::Tiny

OK, in 2015 File::Slurp::Tiny is discouraged and Leon recommends File::Slurper

OK, <irony> what will come next in 2016? </irony>

I am in no way a fan of File::Slurp it is just a module (one of hundreds) that did the job for me in many cases in the past and I know that it works (yes, now I know it may also cause troubles). Changing Perl-Dist-Strawberry is of course possible but it needs some time (my time, my free time, my free unpaid time, you know) for patching and testing and I simply think the achievement in this case will not be worth the effort. BTW: File::Sluper is missing a replacement for append_file which we use.

As for the best practice modules bundled with strawberry: the alternative File::Slurp::Tiny (unfortunately now discouraged) is part of strawberry perl since 5.20.0 (May 2014 - which is approximately the date of our previous discussion about File::Slurp). I have no problem with bundling File::Slurper instead of File::Slurp::Tiny, that's easy.

--
kmx
MIME-Version: 1.0
In-Reply-To: <rt-4.0.18-28725-1443166204-713.107316-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <rt-4.0.18-20555-1443135350-875.0-0-0 [...] rt.cpan.org> <rt-4.0.18-27866-1443148433-365.107316-0-0 [...] rt.cpan.org> <rt-4.0.18-623-1443159629-1861.107316-0-0 [...] rt.cpan.org> <rt-4.0.18-28725-1443166204-713.107316-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.18-15709-1443200000-265.107316-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 291
Download (untitled) / with headers
text/plain 291b
On 2015-09-25 00:30:04, KMX wrote: Show quoted text
> Matt, > > I see your point, it's basically the same as a year ago - > https://rt.cpan.org/Public/Bug/Display.html?id=95482
I apologize for missing the previous ticket. I wouldn't have submitted one if I'd seen there already was one. I'll send a patch.
MIME-Version: 1.0
In-Reply-To: <rt-4.0.18-28725-1443166204-713.107316-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <rt-4.0.18-20555-1443135350-875.0-0-0 [...] rt.cpan.org> <rt-4.0.18-27866-1443148433-365.107316-0-0 [...] rt.cpan.org> <rt-4.0.18-623-1443159629-1861.107316-0-0 [...] rt.cpan.org> <rt-4.0.18-28725-1443166204-713.107316-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.18-27692-1443200235-764.107316-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 1909
Download (untitled) / with headers
text/plain 1.8k
On Fri Sep 25 03:30:04 2015, KMX wrote: Show quoted text
> OK, in 2014 you (or ether?) were recommending File::Slurp::Tiny > > OK, in 2015 File::Slurp::Tiny is discouraged and Leon recommends > File::Slurper
Yeah. Turned out ::Tiny couldn't be made completely sensible due to the API. Show quoted text
> OK, <irony> what will come next in 2016? </irony>
Maybe we'll get readline() in core fixed so we don't need any of this crap at all, there've been rumblings ... Show quoted text
> I am in no way a fan of File::Slurp it is just a module (one of > hundreds) that > did the job for me in many cases in the past and I know that it works > (yes, now > I know it may also cause troubles). Changing Perl-Dist-Strawberry is > of course > possible but it needs some time (my time, my free time, my free unpaid > time, > you know) for patching and testing and I simply think the achievement > in this > case will not be worth the effort.
I wouldn't be upset if you yelled "patches welcome!" and left other people to do the work if they cared enough. Show quoted text
> BTW: File::Sluper is missing a > replacement > for append_file which we use.
No it isn't, there's an append option to write_file. I'm trying to convince leont to add a subroutine for it since people keep not reading the documentation. Show quoted text
> As for the best practice modules bundled with strawberry: the > alternative > File::Slurp::Tiny (unfortunately now discouraged) is part of > strawberry perl > since 5.20.0 (May 2014 - which is approximately the date of our > previous > discussion about File::Slurp). I have no problem with bundling > File::Slurper > instead of File::Slurp::Tiny, that's easy.
I don't consider File::Slurp::Tiny exactly discouraged, if you have File::Slurp code it's almost an s/// whereas File::Slurper requires thinking - and if you want appending, actually reading the docs rather than tl;dr-ing them - so having both around seems like a net win to me. Others may disagree though.
MIME-Version: 1.0
X-Spam-Status: No, score=-5.736 tagged_above=-99.9 required=10 tests=[AWL=0.164, BAYES_00=-1.9, FROM_OUR_RT=-4, RCVD_IN_DNSWL_NONE=-0.0001] autolearn=ham
In-Reply-To: <rt-4.0.18-27692-1443200235-419.107316-5-0 [...] rt.cpan.org>
X-Spam-Flag: NO
X-RT-Interface: API
References: <RT-Ticket-107316 [...] rt.cpan.org> <rt-4.0.18-20555-1443135350-875.107316-5-0 [...] rt.cpan.org> <rt-4.0.18-27866-1443148433-365.107316-5-0 [...] rt.cpan.org> <rt-4.0.18-623-1443159629-1861.107316-5-0 [...] rt.cpan.org> <rt-4.0.18-28725-1443166204-713.107316-5-0 [...] rt.cpan.org> <rt-4.0.18-27692-1443200235-419.107316-5-0 [...] rt.cpan.org>
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
Message-ID: <56058C24.5010003 [...] cpan.org>
content-type: text/plain; charset="utf-8"; format="flowed"
X-RT-Original-Encoding: utf-8
X-Spam-Score: -5.736
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id 94CAE24058B for <cpan-bug+perl-dist-strawberry [...] hipster.bestpractical.com>; Fri, 25 Sep 2015 14:02:45 -0400 (EDT)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jiUubv+YimNW for <cpan-bug+perl-dist-strawberry [...] hipster.bestpractical.com>; Fri, 25 Sep 2015 14:02:41 -0400 (EDT)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id 30B2B24025B for <bug-perl-dist-strawberry [...] rt.cpan.org>; Fri, 25 Sep 2015 14:02:40 -0400 (EDT)
Received: (qmail 11809 invoked by alias); 25 Sep 2015 18:02:37 -0000
Received: from fep13.mx.upcmail.net (HELO fep13.mx.upcmail.net) (62.179.121.33) by la.mx.develooper.com (qpsmtpd/0.28) with ESMTP; Fri, 25 Sep 2015 11:02:25 -0700
Received: from edge01.upcmail.net ([192.168.13.236]) by viefep13-int.chello.at (InterMail vM.8.01.05.18 201-2260-151-151-20140610) with ESMTP id <20150925180219.IZZY9696.viefep13-int.chello.at [...] edge01.upcmail.net> for <bug-perl-dist-strawberry [...] rt.cpan.org>; Fri, 25 Sep 2015 20:02:19 +0200
Received: from [192.168.9.200] ([89.176.203.233]) by edge01.upcmail.net with edge id MW2C1r01E52fSkh01W2DSF; Fri, 25 Sep 2015 20:02:19 +0200
Delivered-To: cpan-bug+perl-dist-strawberry [...] hipster.bestpractical.com
Subject: Re: [rt.cpan.org #107316] uses File::Slurp
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0
Return-Path: <kmx [...] cpan.org>
X-Spam-Check-BY: la.mx.develooper.com
X-Original-To: cpan-bug+perl-dist-strawberry [...] hipster.bestpractical.com
X-RT-Mail-Extension: perl-dist-strawberry
Date: Fri, 25 Sep 2015 20:02:12 +0200
X-Sourceip: 89.176.203.233
X-Spam-Level:
To: bug-Perl-Dist-Strawberry [...] rt.cpan.org
Content-Transfer-Encoding: 7bit
From: kmx <kmx [...] cpan.org>
RT-Message-ID: <rt-4.0.18-22209-1443204166-1298.107316-0-0 [...] rt.cpan.org>
Content-Length: 1113
Matt, Show quoted text
> I wouldn't be upset if you yelled "patches welcome!" and left other people to do the work if they cared enough.
Unfortunately Perl-Dist-Strawberry is not like: 1/ make patch, 2/ run make test, 3/ submit pull request, 4/ accept pull request. You have to run at least one complete build of a strawberry distribution - all ZIPs + MSI (FYI: full build of 5.20.3 lasted 11 hours - for testing the patch I can cut it to let's say 3-4h, but still) + check whether the newly built distribution is OK (e.g. compare it with a ZIP built w/o the patch which means another 3-4h). Again, it is doable, but for me it is not only a click on "accept pull request" button. Show quoted text
>> BTW: File::Sluper is missing a replacement for append_file which we use.
> No it isn't, there's an append option to write_file. > > I'm trying to convince leont to add a subroutine for it since people keep not reading the documentation.
Now I am a bit unsure whether we are talking about the same File::Slurper - https://metacpan.org/source/LEONT/File-Slurper-0.008/lib/File/Slurper.pm - I do not see any append-like option. -- kmx


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.