Skip Menu |
 

This queue is for tickets about the File-Path CPAN distribution.

Report information
The Basics
Id: 106296
Status: resolved
Priority: 0/
Queue: File-Path

People
Owner: Nobody in particular
Requestors: craigberry [...] mac.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

Attachments


MIME-Version: 1.0 (Mac OS X Mail 8.2 \(2102\))
X-Spam-Status: No, score=-4.874 tagged_above=-99.9 required=10 tests=[AWL=0.614, BAYES_00=-1.9, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_MED=-2.3, RP_MATCHES_RCVD=-1.289] autolearn=ham
X-Mailer: Apple Mail (2.2102)
X-Spam-Flag: NO
X-Virus-Checked: Checked
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=1 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=7.0.1-1412110000 definitions=main-1508070355
Message-ID: <75279DBD-11AB-4553-9A04-A7E3703F83F9 [...] mac.com>
Content-Type: multipart/mixed; boundary="Apple-Mail=_A7B319D0-2FCB-431B-B20F-B3BE292B3136"
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
X-Spam-Score: -4.874
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id 0C5A12405EC for <cpan-bug+File-Path [...] hipster.bestpractical.com>; Fri, 7 Aug 2015 16:55:16 -0400 (EDT)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id PyKLiLhO1UZC for <cpan-bug+File-Path [...] hipster.bestpractical.com>; Fri, 7 Aug 2015 16:55:14 -0400 (EDT)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id 5C5B3240379 for <bugs-File-Path [...] rt.cpan.org>; Fri, 7 Aug 2015 16:55:14 -0400 (EDT)
Received: (qmail 5962 invoked by alias); 7 Aug 2015 20:55:13 -0000
Received: from nk11p03mm-asmtpout001.mac.com (HELO nk11p03mm-asmtp001.mac.com) (17.158.232.236) by la.mx.develooper.com (qpsmtpd/0.28) with ESMTP; Fri, 07 Aug 2015 13:55:10 -0700
Received: from [172.16.52.2] (c-24-14-137-179.hsd1.il.comcast.net [24.14.137.179]) by nk11p03mm-asmtp001.mac.com (Oracle Communications Messaging Server 7.0.5.35.0 64bit (built Mar 31 2015)) with ESMTPSA id <0NSQ00C25CRC1J20 [...] nk11p03mm-asmtp001.mac.com> for bugs-File-Path [...] rt.cpan.org; Fri, 07 Aug 2015 20:54:50 +0000 (GMT)
Delivered-To: cpan-bug+File-Path [...] hipster.bestpractical.com
Subject: Some Path.t fixes for VMS plus other failures
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.14.151,1.0.33,0.0.0000 definitions=2015-08-07_09:2015-08-07,2015-08-07,1970-01-01 signatures=0
Return-Path: <craigberry [...] mac.com>
X-RT-Mail-Extension: file-path
X-Original-To: cpan-bug+File-Path [...] hipster.bestpractical.com
X-Spam-Check-BY: la.mx.develooper.com
Date: Fri, 07 Aug 2015 15:54:48 -0500
X-Spam-Level:
To: bugs-File-Path [...] rt.cpan.org
From: "Craig A. Berry" <craigberry [...] mac.com>
X-RT-Interface: Email
Content-Length: 0
content-type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
X-RT-Original-Encoding: utf-8
Content-Length: 3111
There were several new test failures when 2.11 came into blead. The attached fixes those. As I was testing this, I ran against current head from github and found that there are a bunch of additional failures in the verbose mode tests. These tests were exposed by the removal of the requirement for Test::Output so had probably never been run before on VMS. There are two basic problems I can see right off, detailed output below. In verbose mode, mkdir reports what it’s working on in Unix format on VMS, whereas the test has constructed expectations from catdir, which always returns a path in native format. In safe mode, rmtree reports "skipped" when it can’t remove a directory without changing permissions. The difference on VMS is that the default protection for directories does not allow deletion without explicitly changing protection, but the test assumes that directories can always be deleted without doing so. ok 96 # skip Mode of 0 means assume user defaults on VMS not ok 97 - mkpath verbose (old style 1) # Failed test 'mkpath verbose (old style 1)' # at t/Path.t line 487. # got: 'mkdir test-55c51426-437-17bae/output # mkdir test-55c51426-437-17bae/output/A/ # ' # expected: 'mkdir [.test-55c51426-437-17bae.output] # mkdir [.test-55c51426-437-17bae.output.A] # ' not ok 98 - mkpath verbose (old style 2) # Failed test 'mkpath verbose (old style 2)' # at t/Path.t line 492. # got: 'mkdir test-55c51426-437-17bae/output/B/ # ' # expected: 'mkdir [.test-55c51426-437-17bae.output.B] # ' not ok 99 - rmtree verbose (old style) # Failed test 'rmtree verbose (old style)' # at t/Path.t line 497. # got: 'skipped [.test-55c51426-437-17bae.output.A] # skipped [.test-55c51426-437-17bae.output.B] # ' # expected: 'rmdir [.test-55c51426-437-17bae.output.A] # rmdir [.test-55c51426-437-17bae.output.B] # ' not ok 100 - mkpath verbose (new style 1) # Failed test 'mkpath verbose (new style 1)' # at t/Path.t line 502. # got: '' # expected: 'mkdir [.test-55c51426-437-17bae.output.A] # ' not ok 101 - mkpath verbose (new style 2) # Failed test 'mkpath verbose (new style 2)' # at t/Path.t line 507. # got: '' # expected: 'mkdir [.test-55c51426-437-17bae.output.B] # ' not ok 102 - again: rmtree verbose (old style) # Failed test 'again: rmtree verbose (old style)' # at t/Path.t line 512. # got: 'skipped [.test-55c51426-437-17bae.output.A] # skipped [.test-55c51426-437-17bae.output.B] # ' # expected: 'rmdir [.test-55c51426-437-17bae.output.A] # rmdir [.test-55c51426-437-17bae.output.B] # ' not ok 103 - make_path verbose with final hashref # Failed test 'make_path verbose with final hashref' # at t/Path.t line 517. # got: '' # expected: 'mkdir [.test-55c51426-437-17bae.output.A] # mkdir [.test-55c51426-437-17bae.output.B] # ' ok 104 - remove_tree verbose with final hashref Show quoted text
________________________________________ Craig A. Berry mailto:craigberry@mac.com "... getting out of a sonnet is much more difficult than getting in." Brad Leithauser
Content-Type: application/octet-stream; name="0001-Some-Path.t-fixes-for-VMS.patch"
Content-Disposition: attachment; filename="0001-Some-Path.t-fixes-for-VMS.patch"
Content-Transfer-Encoding: quoted-printable
Content-Length: 1271

Message body is not shown because sender requested not to inline it.

MIME-Version: 1.0
In-Reply-To: <75279DBD-11AB-4553-9A04-A7E3703F83F9 [...] mac.com>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <75279DBD-11AB-4553-9A04-A7E3703F83F9 [...] mac.com>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.18-21149-1438987334-869.106296-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 397
Download (untitled) / with headers
text/plain 397b
On Fri Aug 07 16:55:17 2015, craigberry@mac.com wrote: Show quoted text
> There were several new test failures when 2.11 came into blead. The > attached fixes those. >
HI Craig, thanks so much for this! Would you like to do a Github pull request on this? Or would you rather I just apply the patch? The reason I ask is I would prefer it to be a pull request, but if you're not up for it just let me know.
MIME-Version: 1.0 (Mac OS X Mail 8.2 \(2102\))
X-Spam-Status: No, score=-7.079 tagged_above=-99.9 required=10 tests=[AWL=2.409, BAYES_00=-1.9, FREEMAIL_FROM=0.001, FROM_OUR_RT=-4, RCVD_IN_DNSWL_MED=-2.3, RP_MATCHES_RCVD=-1.289] autolearn=ham
In-Reply-To: <rt-4.0.18-21149-1438987334-28.106296-6-0 [...] rt.cpan.org>
X-Mailer: Apple Mail (2.2102)
X-Spam-Flag: NO
X-RT-Interface: API
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=1 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=7.0.1-1412110000 definitions=main-1508070387
References: <RT-Ticket-106296 [...] rt.cpan.org> <75279DBD-11AB-4553-9A04-A7E3703F83F9 [...] mac.com> <rt-4.0.18-21149-1438987334-28.106296-6-0 [...] rt.cpan.org>
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
content-type: text/plain; charset="utf-8"
Message-ID: <584867AA-052C-4CAA-BD3F-60A7BD6C601B [...] mac.com>
X-RT-Original-Encoding: utf-8
X-Spam-Score: -7.079
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id BA7BF2405DE for <cpan-bug+File-Path [...] hipster.bestpractical.com>; Fri, 7 Aug 2015 18:44:36 -0400 (EDT)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LyTLD611MrCe for <cpan-bug+File-Path [...] hipster.bestpractical.com>; Fri, 7 Aug 2015 18:44:35 -0400 (EDT)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id 832062403B9 for <bug-File-Path [...] rt.cpan.org>; Fri, 7 Aug 2015 18:44:35 -0400 (EDT)
Received: (qmail 11038 invoked by alias); 7 Aug 2015 22:44:34 -0000
Received: from nk11p03mm-asmtp001.mac.com (HELO nk11p03mm-asmtp001.mac.com) (17.158.232.236) by la.mx.develooper.com (qpsmtpd/0.28) with ESMTP; Fri, 07 Aug 2015 15:44:32 -0700
Received: from [172.16.52.2] (c-24-14-137-179.hsd1.il.comcast.net [24.14.137.179]) by nk11p03mm-asmtp001.mac.com (Oracle Communications Messaging Server 7.0.5.35.0 64bit (built Mar 31 2015)) with ESMTPSA id <0NSQ00II9HU3LW30 [...] nk11p03mm-asmtp001.mac.com> for bug-File-Path [...] rt.cpan.org; Fri, 07 Aug 2015 22:44:28 +0000 (GMT)
Delivered-To: cpan-bug+File-Path [...] hipster.bestpractical.com
Subject: Re: [rt.cpan.org #106296] Some Path.t fixes for VMS plus other failures
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.14.151,1.0.33,0.0.0000 definitions=2015-08-07_10:2015-08-07,2015-08-07,1970-01-01 signatures=0
Return-Path: <craigberry [...] mac.com>
X-Spam-Check-BY: la.mx.develooper.com
X-Original-To: cpan-bug+File-Path [...] hipster.bestpractical.com
X-RT-Mail-Extension: file-path
Date: Fri, 07 Aug 2015 17:44:26 -0500
X-Spam-Level:
To: bug-File-Path [...] rt.cpan.org
Content-Transfer-Encoding: quoted-printable
From: "Craig A. Berry" <craigberry [...] mac.com>
RT-Message-ID: <rt-4.0.18-17720-1438987477-1425.106296-0-0 [...] rt.cpan.org>
Content-Length: 779
Download (untitled) / with headers
text/plain 779b
Show quoted text
> On Aug 7, 2015, at 5:42 PM, Richard Elberger via RT <bug-File-Path@rt.cpan.org> wrote: > > <URL: https://rt.cpan.org/Ticket/Display.html?id=106296 > > > On Fri Aug 07 16:55:17 2015, craigberry@mac.com wrote:
>> There were several new test failures when 2.11 came into blead. The >> attached fixes those. >>
> > HI Craig, thanks so much for this! > > Would you like to do a Github pull request on this? Or would you rather I just apply the patch? The reason I ask is I would prefer it to be a pull request, but if you're not up for it just let me know.
Please apply the patch. Show quoted text
________________________________________ Craig A. Berry mailto:craigberry@mac.com "... getting out of a sonnet is much more difficult than getting in." Brad Leithauser
MIME-Version: 1.0
In-Reply-To: <rt-4.0.18-17720-1438987477-1425.106296-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <RT-Ticket-106296 [...] rt.cpan.org> <75279DBD-11AB-4553-9A04-A7E3703F83F9 [...] mac.com> <rt-4.0.18-21149-1438987334-28.106296-6-0 [...] rt.cpan.org> <584867AA-052C-4CAA-BD3F-60A7BD6C601B [...] mac.com> <rt-4.0.18-17720-1438987477-1425.106296-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.18-21149-1438988217-1126.106296-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 279
Download (untitled) / with headers
text/plain 279b
Show quoted text
> Please apply the patch.
Done. https://github.com/rpcme/File-Path/commit/2e9dc4a8db12b8a7f79dce9785c32378ce688c88 I will need to work it out with Jim if we can push a new release so it can be picked up. The impact is very limited so I won't cut a dev release for it just yet.
MIME-Version: 1.0 (Mac OS X Mail 8.2 \(2102\))
X-Spam-Status: No, score=-7.681 tagged_above=-99.9 required=10 tests=[AWL=1.807, BAYES_00=-1.9, FREEMAIL_FROM=0.001, FROM_OUR_RT=-4, RCVD_IN_DNSWL_MED=-2.3, RP_MATCHES_RCVD=-1.289] autolearn=ham
In-Reply-To: <rt-4.0.18-21149-1438988224-1110.106296-10-0 [...] rt.cpan.org>
X-Mailer: Apple Mail (2.2102)
X-Spam-Flag: NO
X-RT-Interface: API
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=1 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=7.0.1-1412110000 definitions=main-1508070402
References: <RT-Ticket-106296 [...] rt.cpan.org> <rt-4.0.18-21149-1438988224-1110.106296-10-0 [...] rt.cpan.org>
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
content-type: text/plain; charset="utf-8"
Message-ID: <07009563-3140-4364-816A-FD9003D68A9D [...] mac.com>
X-RT-Original-Encoding: utf-8
X-Spam-Score: -7.681
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id 5EB9C2403B9 for <cpan-bug+File-Path [...] hipster.bestpractical.com>; Fri, 7 Aug 2015 19:33:35 -0400 (EDT)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lj8Al-xG55QL for <cpan-bug+File-Path [...] hipster.bestpractical.com>; Fri, 7 Aug 2015 19:33:34 -0400 (EDT)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id BE8F9240379 for <bug-File-Path [...] rt.cpan.org>; Fri, 7 Aug 2015 19:33:33 -0400 (EDT)
Received: (qmail 14111 invoked by alias); 7 Aug 2015 23:33:33 -0000
Received: from nk11p03mm-asmtpout001.mac.com (HELO nk11p03mm-asmtp001.mac.com) (17.158.232.236) by la.mx.develooper.com (qpsmtpd/0.28) with ESMTP; Fri, 07 Aug 2015 16:33:25 -0700
Received: from [172.16.52.2] (c-24-14-137-179.hsd1.il.comcast.net [24.14.137.179]) by nk11p03mm-asmtp001.mac.com (Oracle Communications Messaging Server 7.0.5.35.0 64bit (built Mar 31 2015)) with ESMTPSA id <0NSQ00MIDK3DAH30 [...] nk11p03mm-asmtp001.mac.com> for bug-File-Path [...] rt.cpan.org; Fri, 07 Aug 2015 23:33:15 +0000 (GMT)
Delivered-To: cpan-bug+File-Path [...] hipster.bestpractical.com
Subject: Re: [rt.cpan.org #106296] Resolved: Some Path.t fixes for VMS plus other failures
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.14.151,1.0.33,0.0.0000 definitions=2015-08-08_01:2015-08-07,2015-08-07,1970-01-01 signatures=0
Return-Path: <craigberry [...] mac.com>
X-Spam-Check-BY: la.mx.develooper.com
X-Original-To: cpan-bug+File-Path [...] hipster.bestpractical.com
X-RT-Mail-Extension: file-path
Date: Fri, 07 Aug 2015 18:33:13 -0500
X-Spam-Level:
To: bug-File-Path [...] rt.cpan.org
Content-Transfer-Encoding: quoted-printable
From: "Craig A. Berry" <craigberry [...] mac.com>
RT-Message-ID: <rt-4.0.18-24369-1438990416-638.106296-0-0 [...] rt.cpan.org>
Content-Length: 706
Download (untitled) / with headers
text/plain 706b
Show quoted text
> On Aug 7, 2015, at 5:57 PM, Richard Elberger via RT <bug-File-Path@rt.cpan.org> wrote: > > <URL: https://rt.cpan.org/Ticket/Display.html?id=106296 > > > According to our records, your request has been resolved. If you have any > further questions or concerns, please respond to this message.
Do note that the patch only addressed one set of test failures and not the set for which the test output was shown in the original ticket submission. I think the ticket should remain open until those can be addressed. Show quoted text
________________________________________ Craig A. Berry mailto:craigberry@mac.com "... getting out of a sonnet is much more difficult than getting in." Brad Leithauser
MIME-Version: 1.0
In-Reply-To: <rt-4.0.18-24369-1438990416-638.106296-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <RT-Ticket-106296 [...] rt.cpan.org> <rt-4.0.18-21149-1438988224-1110.106296-10-0 [...] rt.cpan.org> <07009563-3140-4364-816A-FD9003D68A9D [...] mac.com> <rt-4.0.18-24369-1438990416-638.106296-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.18-11010-1439027734-1876.106296-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 408
Download (untitled) / with headers
text/plain 408b
Show quoted text
> Do note that the patch only addressed one set of test failures and not > the set for which the test output was shown in the original ticket > submission. I think the ticket should remain open until those can be > addressed.
Please open another ticket or I can do so. It's better to have one issue for one ticket ... that's why mistakes like closing this ticket without touching all the points happens.
MIME-Version: 1.0
In-Reply-To: <rt-4.0.18-24369-1438990416-638.106296-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <RT-Ticket-106296 [...] rt.cpan.org> <rt-4.0.18-21149-1438988224-1110.106296-10-0 [...] rt.cpan.org> <07009563-3140-4364-816A-FD9003D68A9D [...] mac.com> <rt-4.0.18-24369-1438990416-638.106296-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.18-14098-1439028195-1761.106296-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 241
Download (untitled) / with headers
text/plain 241b
Show quoted text
> Do note that the patch only addressed one set of test failures and not > the set for which the test output was shown in the original ticket > submission. I think the ticket should remain open until those can be > addressed.
nm I will do


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.