| MIME-Version: | 1.0 |
| X-Spam-Status: | No, score=-2.638 tagged_above=-99.9 required=10 tests=[AWL=-0.738, BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, T_MANY_HDRS_LCASE=0.01, T_RP_MATCHES_RCVD=-0.01] autolearn=ham |
| X-Spam-Flag: | NO |
| content-type: | text/plain; charset="utf-8"; format="flowed" |
| Message-ID: | <558EAF4A.7070803@verizon.net> |
| X-Virus-Scanned: | Debian amavisd-new at bestpractical.com |
| X-Spam-Score: | -2.638 |
| Received: | from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id A02442403DF for <cpan-bug+File-Path@hipster.bestpractical.com>; Sat, 27 Jun 2015 10:12:55 -0400 (EDT) |
| Received: | from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vBgYwm0CltTJ for <cpan-bug+File-Path@hipster.bestpractical.com>; Sat, 27 Jun 2015 10:12:54 -0400 (EDT) |
| Received: | from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id 5ECEA2401A2 for <bug-File-Path@rt.cpan.org>; Sat, 27 Jun 2015 10:12:54 -0400 (EDT) |
| Received: | (qmail 25801 invoked by alias); 27 Jun 2015 14:12:54 -0000 |
| Received: | from vms173025pub.verizon.net (HELO vms173025pub.verizon.net) (206.46.173.25) by la.mx.develooper.com (qpsmtpd/0.28) with ESMTP; Sat, 27 Jun 2015 07:12:49 -0700 |
| Received: | from [192.168.1.45] ([71.246.121.250]) by vms173025.mailsrvcs.net (Oracle Communications Messaging Server 7.0.5.32.0 64bit (built Jul 16 2014)) with ESMTPA id <0NQL003S7WSRLB50@vms173025.mailsrvcs.net> for bug-File-Path@rt.cpan.org; Sat, 27 Jun 2015 09:12:28 -0500 (CDT) |
| X-Cmae-Score: | 0 |
| X-Cmae-Analysis: | v=2.1 cv=Lv5vsSpc c=1 sm=1 tr=0 a=a8EHXXCuOaJhz+/e/T3X/w==:117 a=o1OHuDzbAAAA:8 a=oR5dmqMzAAAA:8 a=hTJJpgObMeYA:10 a=-9mUelKeXuEA:10 a=IkcTkHD0fZMA:10 a=XAFQembCKUMA:10 a=Y81ml3FW3SLMGVTP3b0A:9 a=QEXdDO2ut3YA:10 |
| Delivered-To: | cpan-bug+File-Path@hipster.bestpractical.com |
| Subject: | eg/setup-extra-tests: Should these be reformulated as 'author tests'? |
| User-Agent: | Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 |
| Return-Path: | <jkeen@verizon.net> |
| X-RT-Mail-Extension: | file-path |
| X-Original-To: | cpan-bug+File-Path@hipster.bestpractical.com |
| X-Spam-Check-BY: | la.mx.develooper.com |
| Date: | Sat, 27 Jun 2015 10:12:26 -0400 |
| X-Spam-Level: | |
| To: | bug-File-Path@rt.cpan.org |
| Content-Transfer-Encoding: | 7bit |
| From: | James E Keenan <jkeen@verizon.net> |
| X-RT-Original-Encoding: | utf-8 |
| X-RT-Interface: | |
| Content-Length: | 1585 |
The File-Path distribution currently contains a directory 'eg/' which
holds one file 'setup-extra-tests'. It appears that this file prepares
extra tests to be run in t/Path.t when tests are being run by root:
#####
$ head -6 eg/setup-extra-tests
use strict;
use File::Path; # heh
use Getopt::Std;
die "Not running as root (uid=$<)\n" if $<;
#####
I haven't actually run the tests as root yet -- if only because as a
developer I *never* run anything as root in my day-to-day work either
for $job of for OS -- but I'm wondering if it would be better to follow
current CPAN best practices and consider this an "author test" which
should be placed in a directory called 'xt/'.
We already have to exclude eg/setup-extra-tests from inclusion in the
Perl 5 core distribution. From Porting/Maintainers.pl:
#####
'File::Path' => {
'DISTRIBUTION' => 'DLAND/File-Path-2.09.tar.gz',
'FILES' => q[cpan/File-Path],
'EXCLUDED' => [
qw( eg/setup-extra-tests
t/pod.t
)
],
'MAP' => {
'' => 'cpan/File-Path/lib/File/',
't/' => 'cpan/File-Path/t/',
},
},
#####
If we were to move these tests to 'xt/', we could simplify the
'EXCLUDED' element above to '[ qr{^xt} ]', which many other dual-life
distributions follow.
Consider this a suggestion, not a full-fledged bug report or feature
request. Some data we might want to gather when evaluating this
suggestion: Do CPANtesters run these extra tests?
Thank you very much.
Jim Keenan