This queue is for tickets about the File-Path CPAN distribution.

Report information
The Basics
Id:
105527
Status:
resolved
Priority:
Low/Low
Queue:

People
Owner:
jkeenan [...] cpan.org
Requestors:
jkeen [...] verizon.net
Cc:
AdminCc:

BugTracker
Severity:
(no value)
Broken in:
(no value)
Fixed in:
(no value)



MIME-Version: 1.0
X-Spam-Status: No, score=-2.638 tagged_above=-99.9 required=10 tests=[AWL=-0.738, BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, T_MANY_HDRS_LCASE=0.01, T_RP_MATCHES_RCVD=-0.01] autolearn=ham
X-Spam-Flag: NO
content-type: text/plain; charset="utf-8"; format="flowed"
Message-ID: <558EAF4A.7070803@verizon.net>
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
X-Spam-Score: -2.638
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id A02442403DF for <cpan-bug+File-Path@hipster.bestpractical.com>; Sat, 27 Jun 2015 10:12:55 -0400 (EDT)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vBgYwm0CltTJ for <cpan-bug+File-Path@hipster.bestpractical.com>; Sat, 27 Jun 2015 10:12:54 -0400 (EDT)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id 5ECEA2401A2 for <bug-File-Path@rt.cpan.org>; Sat, 27 Jun 2015 10:12:54 -0400 (EDT)
Received: (qmail 25801 invoked by alias); 27 Jun 2015 14:12:54 -0000
Received: from vms173025pub.verizon.net (HELO vms173025pub.verizon.net) (206.46.173.25) by la.mx.develooper.com (qpsmtpd/0.28) with ESMTP; Sat, 27 Jun 2015 07:12:49 -0700
Received: from [192.168.1.45] ([71.246.121.250]) by vms173025.mailsrvcs.net (Oracle Communications Messaging Server 7.0.5.32.0 64bit (built Jul 16 2014)) with ESMTPA id <0NQL003S7WSRLB50@vms173025.mailsrvcs.net> for bug-File-Path@rt.cpan.org; Sat, 27 Jun 2015 09:12:28 -0500 (CDT)
X-Cmae-Score: 0
X-Cmae-Analysis: v=2.1 cv=Lv5vsSpc c=1 sm=1 tr=0 a=a8EHXXCuOaJhz+/e/T3X/w==:117 a=o1OHuDzbAAAA:8 a=oR5dmqMzAAAA:8 a=hTJJpgObMeYA:10 a=-9mUelKeXuEA:10 a=IkcTkHD0fZMA:10 a=XAFQembCKUMA:10 a=Y81ml3FW3SLMGVTP3b0A:9 a=QEXdDO2ut3YA:10
Delivered-To: cpan-bug+File-Path@hipster.bestpractical.com
Subject: eg/setup-extra-tests: Should these be reformulated as 'author tests'?
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
Return-Path: <jkeen@verizon.net>
X-RT-Mail-Extension: file-path
X-Original-To: cpan-bug+File-Path@hipster.bestpractical.com
X-Spam-Check-BY: la.mx.develooper.com
Date: Sat, 27 Jun 2015 10:12:26 -0400
X-Spam-Level:
To: bug-File-Path@rt.cpan.org
Content-Transfer-Encoding: 7bit
From: James E Keenan <jkeen@verizon.net>
X-RT-Original-Encoding: utf-8
X-RT-Interface: Email
Content-Length: 1585
The File-Path distribution currently contains a directory 'eg/' which holds one file 'setup-extra-tests'. It appears that this file prepares extra tests to be run in t/Path.t when tests are being run by root: ##### $ head -6 eg/setup-extra-tests use strict; use File::Path; # heh use Getopt::Std; die "Not running as root (uid=$<)\n" if $<; ##### I haven't actually run the tests as root yet -- if only because as a developer I *never* run anything as root in my day-to-day work either for $job of for OS -- but I'm wondering if it would be better to follow current CPAN best practices and consider this an "author test" which should be placed in a directory called 'xt/'. We already have to exclude eg/setup-extra-tests from inclusion in the Perl 5 core distribution. From Porting/Maintainers.pl: ##### 'File::Path' => { 'DISTRIBUTION' => 'DLAND/File-Path-2.09.tar.gz', 'FILES' => q[cpan/File-Path], 'EXCLUDED' => [ qw( eg/setup-extra-tests t/pod.t ) ], 'MAP' => { '' => 'cpan/File-Path/lib/File/', 't/' => 'cpan/File-Path/t/', }, }, ##### If we were to move these tests to 'xt/', we could simplify the 'EXCLUDED' element above to '[ qr{^xt} ]', which many other dual-life distributions follow. Consider this a suggestion, not a full-fledged bug report or feature request. Some data we might want to gather when evaluating this suggestion: Do CPANtesters run these extra tests? Thank you very much. Jim Keenan
MIME-Version: 1.0 (Mac OS X Mail 8.2 \(2098\))
X-Spam-Status: No, score=-5.9 tagged_above=-99.9 required=10 tests=[BAYES_00=-1.9, FROM_OUR_RT=-4, RCVD_IN_DNSWL_NONE=-0.0001] autolearn=ham
In-Reply-To: <rt-4.0.18-27722-1435414377-728.105527-4-0@rt.cpan.org>
X-Mailer: Apple Mail (2.2098)
X-Spam-Flag: NO
X-RT-Interface: API
References: <RT-Ticket-105527@rt.cpan.org> <558EAF4A.7070803@verizon.net> <rt-4.0.18-27722-1435414377-728.105527-4-0@rt.cpan.org>
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
content-type: text/plain; charset="utf-8"
Message-ID: <547DF289-8A68-43AB-9B64-A4C15571BE98@richelberger.com>
X-RT-Original-Encoding: utf-8
X-Spam-Score: -5.9
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id E2914240302 for <cpan-bug+file-path@hipster.bestpractical.com>; Sat, 27 Jun 2015 13:02:39 -0400 (EDT)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dEDOEoDXb1Bx for <cpan-bug+file-path@hipster.bestpractical.com>; Sat, 27 Jun 2015 13:02:38 -0400 (EDT)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id 6ADF42401A2 for <bug-file-path@rt.cpan.org>; Sat, 27 Jun 2015 13:02:38 -0400 (EDT)
Received: (qmail 1651 invoked by alias); 27 Jun 2015 17:02:37 -0000
Received: from p3plsmtpa12-10.prod.phx3.secureserver.net (HELO p3plsmtpa12-10.prod.phx3.secureserver.net) (68.178.252.239) by la.mx.develooper.com (qpsmtpd/0.28) with ESMTP; Sat, 27 Jun 2015 10:02:31 -0700
Received: from ananke.t-mobile.com ([75.133.97.212]) by p3plsmtpa12-10.prod.phx3.secureserver.net with id lV2S1q0054aw6v701V2S1i; Sat, 27 Jun 2015 10:02:27 -0700
Delivered-To: cpan-bug+file-path@hipster.bestpractical.com
Subject: Re: [rt.cpan.org #105527] eg/setup-extra-tests: Should these be reformulated as 'author tests'?
Return-Path: <rich@richelberger.com>
X-Spam-Check-BY: la.mx.develooper.com
X-Original-To: cpan-bug+file-path@hipster.bestpractical.com
X-RT-Mail-Extension: file-path
Date: Sat, 27 Jun 2015 13:02:26 -0400
X-Spam-Level:
To: bug-File-Path@rt.cpan.org
Content-Transfer-Encoding: quoted-printable
From: Richard Elberger <rich@richelberger.com>
RT-Message-ID: <rt-4.0.18-26224-1435424560-1995.105527-0-0@rt.cpan.org>
Content-Length: 2547
100% agree that any test expected to be run as root or maintainer mode only should be in xt/ which as you say is the norm today. To add, from an administrator’s perspective I wouldn’t want anything potentially destructive run as privileged user (root or Administrators group on Windows) … i.e. into system perl … so IMO the sooner the better.
Show quoted text
> On Jun 27, 2015, at 10:12 AM, jkeen@verizon.net via RT <bug-File-Path@rt.cpan.org> wrote: > > Sat Jun 27 10:12:57 2015: Request 105527 was acted upon. > Transaction: Ticket created by jkeen@verizon.net > Queue: File-Path > Subject: eg/setup-extra-tests: Should these be reformulated as 'author tests'? > Broken in: (no value) > Severity: (no value) > Owner: Nobody > Requestors: jkeen@verizon.net > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=105527 > > > > The File-Path distribution currently contains a directory 'eg/' which > holds one file 'setup-extra-tests'. It appears that this file prepares > extra tests to be run in t/Path.t when tests are being run by root: > > ##### > $ head -6 eg/setup-extra-tests > use strict; > use File::Path; # heh > use Getopt::Std; > > die "Not running as root (uid=$<)\n" if $<; > > ##### > > I haven't actually run the tests as root yet -- if only because as a > developer I *never* run anything as root in my day-to-day work either > for $job of for OS -- but I'm wondering if it would be better to follow > current CPAN best practices and consider this an "author test" which > should be placed in a directory called 'xt/'. > > We already have to exclude eg/setup-extra-tests from inclusion in the > Perl 5 core distribution. From Porting/Maintainers.pl: > > ##### > 'File::Path' => { > 'DISTRIBUTION' => 'DLAND/File-Path-2.09.tar.gz', > 'FILES' => q[cpan/File-Path], > 'EXCLUDED' => [ > qw( eg/setup-extra-tests > t/pod.t > ) > ], > 'MAP' => { > '' => 'cpan/File-Path/lib/File/', > 't/' => 'cpan/File-Path/t/', > }, > }, > ##### > > If we were to move these tests to 'xt/', we could simplify the > 'EXCLUDED' element above to '[ qr{^xt} ]', which many other dual-life > distributions follow. > > Consider this a suggestion, not a full-fledged bug report or feature > request. Some data we might want to gather when evaluating this > suggestion: Do CPANtesters run these extra tests? > > Thank you very much. > Jim Keenan > >
MIME-Version: 1.0
In-Reply-To: <rt-4.0.18-26224-1435424560-1995.105527-0-0@rt.cpan.org>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <RT-Ticket-105527@rt.cpan.org> <558EAF4A.7070803@verizon.net> <rt-4.0.18-27722-1435414377-728.105527-4-0@rt.cpan.org> <547DF289-8A68-43AB-9B64-A4C15571BE98@richelberger.com> <rt-4.0.18-26224-1435424560-1995.105527-0-0@rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.18-1704-1435426351-1823.105527-0-0@rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 2858
On Sat Jun 27 13:02:40 2015, rich@richelberger.com wrote:
Show quoted text
> 100% agree that any test expected to be run as root or maintainer mode > only should be in xt/ which as you say is the norm today. > > To add, from an administrator’s perspective I wouldn’t want anything > potentially destructive run as privileged user (root or Administrators > group on Windows) … i.e. into system perl … so IMO the sooner the > better. > >
> > On Jun 27, 2015, at 10:12 AM, jkeen@verizon.net via RT <bug-File- > > Path@rt.cpan.org> wrote: > > > > Sat Jun 27 10:12:57 2015: Request 105527 was acted upon. > > Transaction: Ticket created by jkeen@verizon.net > > Queue: File-Path > > Subject: eg/setup-extra-tests: Should these be reformulated as > > 'author tests'? > > Broken in: (no value) > > Severity: (no value) > > Owner: Nobody > > Requestors: jkeen@verizon.net > > Status: new > > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=105527 > > > > > > > The File-Path distribution currently contains a directory 'eg/' which > > holds one file 'setup-extra-tests'. It appears that this file > > prepares > > extra tests to be run in t/Path.t when tests are being run by root: > > > > ##### > > $ head -6 eg/setup-extra-tests > > use strict; > > use File::Path; # heh > > use Getopt::Std; > > > > die "Not running as root (uid=$<)\n" if $<; > > > > ##### > > > > I haven't actually run the tests as root yet -- if only because as a > > developer I *never* run anything as root in my day-to-day work either > > for $job of for OS -- but I'm wondering if it would be better to > > follow > > current CPAN best practices and consider this an "author test" which > > should be placed in a directory called 'xt/'. > > > > We already have to exclude eg/setup-extra-tests from inclusion in the > > Perl 5 core distribution. From Porting/Maintainers.pl: > > > > ##### > > 'File::Path' => { > > 'DISTRIBUTION' => 'DLAND/File-Path-2.09.tar.gz', > > 'FILES' => q[cpan/File-Path], > > 'EXCLUDED' => [ > > qw( eg/setup-extra-tests > > t/pod.t > > ) > > ], > > 'MAP' => { > > '' => 'cpan/File-Path/lib/File/', > > 't/' => 'cpan/File-Path/t/', > > }, > > }, > > ##### > > > > If we were to move these tests to 'xt/', we could simplify the > > 'EXCLUDED' element above to '[ qr{^xt} ]', which many other dual-life > > distributions follow. > > > > Consider this a suggestion, not a full-fledged bug report or feature > > request. Some data we might want to gather when evaluating this > > suggestion: Do CPANtesters run these extra tests? > > > > Thank you very much. > > Jim Keenan > > > >
I'll have to set aside time to study eg/setup-extra-tests more thoroughly. Once I'm confident I understand it, I'll prepare a patch. Thank you very much. Jim Keenan
MIME-Version: 1.0
In-Reply-To: <rt-4.0.18-1704-1435426351-1823.105527-0-0@rt.cpan.org>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <RT-Ticket-105527@rt.cpan.org> <558EAF4A.7070803@verizon.net> <rt-4.0.18-27722-1435414377-728.105527-4-0@rt.cpan.org> <547DF289-8A68-43AB-9B64-A4C15571BE98@richelberger.com> <rt-4.0.18-26224-1435424560-1995.105527-0-0@rt.cpan.org> <rt-4.0.18-1704-1435426351-1823.105527-0-0@rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.18-15949-1437576967-1138.105527-0-0@rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 166
I have removed author tests from Path.t and put them into xt/extra.t. Next I will take code from eg/ and put it in the file to setup those specific set of tests.
MIME-Version: 1.0
In-Reply-To: <rt-4.0.18-15949-1437576967-1138.105527-0-0@rt.cpan.org>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <RT-Ticket-105527@rt.cpan.org> <558EAF4A.7070803@verizon.net> <rt-4.0.18-27722-1435414377-728.105527-4-0@rt.cpan.org> <547DF289-8A68-43AB-9B64-A4C15571BE98@richelberger.com> <rt-4.0.18-26224-1435424560-1995.105527-0-0@rt.cpan.org> <rt-4.0.18-1704-1435426351-1823.105527-0-0@rt.cpan.org> <rt-4.0.18-15949-1437576967-1138.105527-0-0@rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.18-28918-1437597565-1658.105527-0-0@rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 409
On Wed Jul 22 10:56:07 2015, RICHE wrote:
Show quoted text
> I have removed author tests from Path.t and put them into xt/extra.t. > Next I will take code from eg/ and put it in the file to setup those > specific set of tests.
These tests have now been formed under xt/. author tests in Path.t have been pulled out and put into xt/extra.t. https://github.com/rpcme/File-Path/commit/8002080391b5c2e449a0c824817e4c7c791e7da7


This service runs on Request Tracker, is sponsored by The Perl Foundation, and maintained by Best Practical Solutions.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.