Skip Menu |
 

This queue is for tickets about the Config-IniFiles CPAN distribution.

Report information
The Basics
Id: 105255
Status: resolved
Priority: 0/
Queue: Config-IniFiles

People
Owner: Nobody in particular
Requestors: rohan [...] digins.net.au
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



X-MS-Exchange-Crosstenant-Fromentityheader: Hosted
MIME-Version: 1.0
X-Spam-Flag: NO
Content-Type: multipart/alternative; boundary="_000_51DD9F5ABAF34E5CB470DFFD0BCE1A36diginsnetau_"
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
X-Exchange-Antispam-Report-Test: UriScan:;
X-Spam-Score: -1.899
Authentication-Results: rt.cpan.org; dkim=none (message not signed) header.d=none;
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id 208BA240562 for <cpan-bug+Config-IniFiles [...] hipster.bestpractical.com>; Tue, 16 Jun 2015 03:59:49 -0400 (EDT)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id FCc0W3JJxUgY for <cpan-bug+Config-IniFiles [...] hipster.bestpractical.com>; Tue, 16 Jun 2015 03:59:46 -0400 (EDT)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id 9148D240559 for <bug-Config-IniFiles [...] rt.cpan.org>; Tue, 16 Jun 2015 03:59:45 -0400 (EDT)
Received: (qmail 26510 invoked by alias); 16 Jun 2015 07:59:44 -0000
Received: from mail-sg1on0145.outbound.protection.outlook.com (HELO APAC01-SG1-obe.outbound.protection.outlook.com) (134.170.132.145) by la.mx.develooper.com (qpsmtpd/0.28) with ESMTP; Tue, 16 Jun 2015 00:59:41 -0700
Received: from TY1PR0201MB0941.apcprd02.prod.outlook.com (10.164.97.140) by TY1PR0201MB0942.apcprd02.prod.outlook.com (10.164.97.141) with Microsoft SMTP Server (TLS) id 15.1.190.14; Tue, 16 Jun 2015 07:59:33 +0000
Received: from TY1PR0201MB0941.apcprd02.prod.outlook.com ([10.164.97.140]) by TY1PR0201MB0941.apcprd02.prod.outlook.com ([10.164.97.140]) with mapi id 15.01.0190.013; Tue, 16 Jun 2015 07:59:33 +0000
Delivered-To: cpan-bug+Config-IniFiles [...] hipster.bestpractical.com
Subject: Config::IniFiles with handle_trailing_comment doesn't parse trailing comments correctly
X-Spam-Check-BY: la.mx.develooper.com
Thread-Index: AQHQqApfjZ5l11xjjk2lXcRmwD5jLQ==
Date: Tue, 16 Jun 2015 07:59:30 +0000
X-Originatororg: digins.net.au
X-Spam-Level:
X-MS-Exchange-Crosstenant-ID: ccd5299b-3876-44e8-b434-0df81c746ec9
To: "bug-Config-IniFiles [...] rt.cpan.org" <bug-Config-IniFiles [...] rt.cpan.org>
X-Exchange-Antispam-Report-Cfa-Test: BCL:0;PCL:0;RULEID:(601004)(520003)(5005006)(3002001);SRVR:TY1PR0201MB0942;BCL:0;PCL:0;RULEID:;SRVR:TY1PR0201MB0942;
X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:TY1PR0201MB0942;
X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6009001)(164054003)(2656002)(229853001)(40100003)(86362001)(83716003)(74482002)(5002640100001)(450100001)(122556002)(92566002)(46102003)(189998001)(87936001)(106116001)(82746002)(5001960100002)(110136002)(77156002)(33656002)(2900100001)(16236675004)(66066001)(5001920100001)(2351001)(2501003)(107886002)(36756003)(77096005)(54356999)(102836002)(50986999);DIR:OUT;SFP:1102;SCL:1;SRVR:TY1PR0201MB0942;H:TY1PR0201MB0941.apcprd02.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en;
X-Spam-Status: No, score=-1.899 tagged_above=-99.9 required=10 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001] autolearn=ham
X-Microsoft-Exchange-Diagnostics: 1;TY1PR0201MB0942;3:zhVsxOHHH9+fR1/Bc2T7zWesLluqT52xQfqUufioYHFbMH7xkloZgEnjsBGzneMZTfLRhqFlkCOwLxGuVxbUCrCCi5FxbeoYnbfjjvoIBfOaaMA0vZZet21XxPoZ37Rrq2WaEzTxdlebs64oT4hlDQ==;10:n0Wioc3euJmK71AbTngX/KpyHLO3a7XvWMcaQgIZp5mfiz5f5qMwlNcYBWLQxDu0CScK56kzYAYiwYjIqFeK2stJMqMnUTK4llaw7o+xmTU=;6:vs0q3PjoEQdwwr/ogOpdHz7BuIe+5qxss4hldoyG155EqXQGd/QmW4hlMFeC9dNY
Content-Language: en-US
Message-ID: <51DD9F5A-BAF3-4E5C-B470-DFFD0BCE1A36 [...] digins.net.au>
X-MS-Tnef-Correlator:
X-Microsoft-Antispam-PRVS: <TY1PR0201MB09429C33290A9EF1547FA9C7F5A70 [...] TY1PR0201MB0942.apcprd02.prod.outlook.com>
Return-Path: <rohan [...] digins.net.au>
X-MS-Exchange-Crosstenant-Originalarrivaltime: 16 Jun 2015 07:59:30.8026 (UTC)
X-Original-To: cpan-bug+Config-IniFiles [...] hipster.bestpractical.com
X-RT-Mail-Extension: config-inifiles
X-Forefront-PRVS: 06098A2863
Thread-Topic: Config::IniFiles with handle_trailing_comment doesn't parse trailing comments correctly
X-MS-Has-Attach:
X-Originating-Ip: [121.45.232.178]
Accept-Language: en-AU, en-US
X-MS-Exchange-Messagesentrepresentingtype: 1
X-MS-Exchange-Transport-Crosstenantheadersstamped: TY1PR0201MB0942
From: Rohan Carly <rohan [...] digins.net.au>
X-RT-Interface: Email
Content-Length: 0
content-type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
X-RT-Original-Encoding: utf-8
Content-Length: 805
Download (untitled) / with headers
text/plain 805b
Dear maintainer, When I insert a comment containing a semicolon into an INI file, I was surprised to see only half of it being treated as a comment, with the reset being treated as part of the parameter value. Here is my test code: #!/usr/bin/env perl use Config::IniFiles; use warnings; my $ini_file_contents = "[abc]\ndog=cat ; a comment ; further comment"; my $c = Config::IniFiles->new( -file=>\$ini_file_contents, -handle_trailing_comment=>1 ); print $c->val("abc","dog")."\n”; Expected output: cat Actual output: cat ; a comment I tried this with version 2.86. I was hoping that you might be able to correct this behaviour. I note that some other INI file parsers, such as crudini (command line util), provide the result I expect. Thanks, -- Rohan Carly
content-type: text/html; charset="utf-8"
Content-Transfer-Encoding: base64
Content-ID: <8F83DF4949F8B44CB8109E69E54577D5 [...] apcprd02.prod.outlook.com>
X-RT-Original-Encoding: utf-8
Content-Length: 1605
MIME-Version: 1.0
In-Reply-To: <51DD9F5A-BAF3-4E5C-B470-DFFD0BCE1A36 [...] digins.net.au>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <51DD9F5A-BAF3-4E5C-B470-DFFD0BCE1A36 [...] digins.net.au>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.18-9129-1434442881-625.105255-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 999
Download (untitled) / with headers
text/plain 999b
On Tue Jun 16 03:59:50 2015, rohan@digins.net.au wrote: Show quoted text
> Dear maintainer, > > When I insert a comment containing a semicolon into an INI file, I was > surprised to see only half of it being treated as a comment, with the > reset being treated as part of the parameter value. > > Here is my test code: > > #!/usr/bin/env perl > use Config::IniFiles; > use warnings; > my $ini_file_contents = "[abc]\ndog=cat ; a comment ; further > comment"; > my $c = Config::IniFiles->new( > -file=>\$ini_file_contents, > -handle_trailing_comment=>1 > ); > print $c->val("abc","dog")."\n”; > > Expected output: cat > Actual output: cat ; a comment > > I tried this with version 2.86. > > I was hoping that you might be able to correct this behaviour. I note > that some other INI file parsers, such as crudini (command line util), > provide the result I expect. >
Hi Rohan, thanks for the report. I'll investigate and try to fix it. Regards, -- Shlomi Fish Show quoted text
> Thanks, > -- > Rohan Carly > >
MIME-Version: 1.0
In-Reply-To: <rt-4.0.18-9129-1434442881-625.105255-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <51DD9F5A-BAF3-4E5C-B470-DFFD0BCE1A36 [...] digins.net.au> <rt-4.0.18-9129-1434442881-625.105255-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.18-17954-1434445977-1782.105255-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 1476
Download (untitled) / with headers
text/plain 1.4k
Hi Rohan, thanks for the report again. I investigated and fixed the problem in Config-IniFiles-2.87 which I just uploaded to CPAN. You may opt to visit my home site on the Web - http://www.shlomifish.org/ and see how to help it - http://www.shlomifish.org/meta/how-to-help/ . Thanks again! Marking as RESOLVED. Regards, -- Shlomi Fish On Tue Jun 16 04:21:21 2015, SHLOMIF wrote: Show quoted text
> On Tue Jun 16 03:59:50 2015, rohan@digins.net.au wrote:
> > Dear maintainer, > > > > When I insert a comment containing a semicolon into an INI file, I was > > surprised to see only half of it being treated as a comment, with the > > reset being treated as part of the parameter value. > > > > Here is my test code: > > > > #!/usr/bin/env perl > > use Config::IniFiles; > > use warnings; > > my $ini_file_contents = "[abc]\ndog=cat ; a comment ; further > > comment"; > > my $c = Config::IniFiles->new( > > -file=>\$ini_file_contents, > > -handle_trailing_comment=>1 > > ); > > print $c->val("abc","dog")."\n”; > > > > Expected output: cat > > Actual output: cat ; a comment > > > > I tried this with version 2.86. > > > > I was hoping that you might be able to correct this behaviour. I note > > that some other INI file parsers, such as crudini (command line util), > > provide the result I expect. > >
> > Hi Rohan, > > thanks for the report. I'll investigate and try to fix it. > > Regards, > > -- Shlomi Fish >
> > Thanks, > > -- > > Rohan Carly > > > >
> >
X-MS-Exchange-Crosstenant-Fromentityheader: Hosted
MIME-Version: 1.0
X-Spam-Flag: NO
X-Virus-Checked: Checked
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
Content-Type: multipart/alternative; boundary="_000_F95883C6A00A43E48A471722087AD45Bdiginsnetau_"
X-Spam-Score: -3.899
X-Exchange-Antispam-Report-Test: UriScan:;
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id 006AB24044C for <cpan-bug+Config-IniFiles [...] hipster.bestpractical.com>; Tue, 16 Jun 2015 08:26:53 -0400 (EDT)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LHfkjRXX8MN3 for <cpan-bug+Config-IniFiles [...] hipster.bestpractical.com>; Tue, 16 Jun 2015 08:26:51 -0400 (EDT)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id 99834240003 for <bug-Config-IniFiles [...] rt.cpan.org>; Tue, 16 Jun 2015 08:26:50 -0400 (EDT)
Received: (qmail 11320 invoked by alias); 16 Jun 2015 12:26:50 -0000
Received: from mail-hk1on0113.outbound.protection.outlook.com (HELO APAC01-HK1-obe.outbound.protection.outlook.com) (134.170.140.113) by la.mx.develooper.com (qpsmtpd/0.28) with ESMTP; Tue, 16 Jun 2015 05:26:42 -0700
Received: from TY1PR0201MB0941.apcprd02.prod.outlook.com (10.164.97.140) by TY1PR0201MB0944.apcprd02.prod.outlook.com (10.164.97.143) with Microsoft SMTP Server (TLS) id 15.1.190.14; Tue, 16 Jun 2015 12:26:34 +0000
Received: from TY1PR0201MB0941.apcprd02.prod.outlook.com ([10.164.97.140]) by TY1PR0201MB0941.apcprd02.prod.outlook.com ([10.164.97.140]) with mapi id 15.01.0190.013; Tue, 16 Jun 2015 12:26:34 +0000
Authentication-Results: rt.cpan.org; dkim=none (message not signed) header.d=none;
Delivered-To: cpan-bug+Config-IniFiles [...] hipster.bestpractical.com
Subject: Re: [rt.cpan.org #105255] Config::IniFiles with handle_trailing_comment doesn't parse trailing comments correctly
Thread-Index: AQHQqApfjZ5l11xjjk2lXcRmwD5jLZ2u2T6DgAC8JAA=
X-Spam-Check-BY: la.mx.develooper.com
Date: Tue, 16 Jun 2015 12:26:33 +0000
X-Originatororg: digins.net.au
X-Spam-Level:
X-MS-Exchange-Crosstenant-ID: ccd5299b-3876-44e8-b434-0df81c746ec9
To: "bug-Config-IniFiles [...] rt.cpan.org" <bug-Config-IniFiles [...] rt.cpan.org>
X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:TY1PR0201MB0944;
X-Exchange-Antispam-Report-Cfa-Test: BCL:0;PCL:0;RULEID:(601004)(520003)(5005006)(3002001);SRVR:TY1PR0201MB0944;BCL:0;PCL:0;RULEID:;SRVR:TY1PR0201MB0944;
X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(479174004)(164054003)(43784003)(51704005)(377454003)(24454002)(51914003)(19580395003)(19617315012)(62966003)(54356999)(87936001)(2501003)(92566002)(93886004)(40100003)(122556002)(82746002)(16236675004)(2900100001)(66066001)(83716003)(76176999)(5002640100001)(450100001)(2351001)(77156002)(189998001)(2950100001)(33656002)(5001960100002)(106116001)(107886002)(19580405001)(77096005)(2656002)(50986999)(15975445007)(86362001)(36756003)(46102003)(110136002)(102836002)(19627235001);DIR:OUT;SFP:1102;SCL:1;SRVR:TY1PR0201MB0944;H:TY1PR0201MB0941.apcprd02.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en;
In-Reply-To: <rt-4.0.18-17954-1434445977-382.105255-6-0 [...] rt.cpan.org>
X-Spam-Status: No, score=-3.899 tagged_above=-99.9 required=10 tests=[AWL=2.000, BAYES_00=-1.9, FROM_OUR_RT=-4, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001] autolearn=ham
X-Microsoft-Exchange-Diagnostics: 1;TY1PR0201MB0944;3:gAhq5G78E+fgg2TTOGx+t06QuBlnEHtjvJYzXeK+h+LHQMiQw69a6PjF9l/yVKktgRRfGPlzrKltvQwY2ZPLdLQtsBbnq2B9Z6cF/pAiQz5NivEiOdUBPvwCK+emLyqcjmZjviwmyLqcW0JbFt2dFQ==;10:XZEzV+qrLJAzQAd2qirm2Xqp6PlNyEzgBJ4jK0yG3TVQCkU1YZott4VR8zEZmFGUueVjHg7GEusmSniItmENu0bcXSrnZ/UIhDTPqMilu+c=;6:CoKGEnxl0QJyz3BvtM3ndHpFxrWGc1g6C2aVJWgGqjEzpWJP7CUrMRJvu6p82vmj
X-RT-Interface: API
Content-Language: en-US
References: <RT-Ticket-105255 [...] rt.cpan.org> <51DD9F5A-BAF3-4E5C-B470-DFFD0BCE1A36 [...] digins.net.au> <rt-4.0.18-9129-1434442881-625.105255-6-0 [...] rt.cpan.org> <rt-4.0.18-17954-1434445977-382.105255-6-0 [...] rt.cpan.org>
Message-ID: <F95883C6-A00A-43E4-8A47-1722087AD45B [...] digins.net.au>
X-Microsoft-Antispam-PRVS: <TY1PR0201MB09447491C18329A4DEC74CCFF5A70 [...] TY1PR0201MB0944.apcprd02.prod.outlook.com>
X-MS-Tnef-Correlator:
Return-Path: <rohan [...] digins.net.au>
X-RT-Mail-Extension: config-inifiles
X-Original-To: cpan-bug+Config-IniFiles [...] hipster.bestpractical.com
X-MS-Exchange-Crosstenant-Originalarrivaltime: 16 Jun 2015 12:26:33.6767 (UTC)
X-Forefront-PRVS: 06098A2863
X-MS-Has-Attach:
Thread-Topic: [rt.cpan.org #105255] Config::IniFiles with handle_trailing_comment doesn't parse trailing comments correctly
X-Originating-Ip: [121.45.233.66]
Accept-Language: en-AU, en-US
X-MS-Exchange-Messagesentrepresentingtype: 1
From: Rohan Carly <rohan [...] digins.net.au>
X-MS-Exchange-Transport-Crosstenantheadersstamped: TY1PR0201MB0944
RT-Message-ID: <rt-4.0.18-3242-1434457614-564.105255-0-0 [...] rt.cpan.org>
Content-Length: 0
content-type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
X-RT-Original-Encoding: utf-8
Content-Length: 1835
Download (untitled) / with headers
text/plain 1.7k
Hi Shlomi Fish, great work. I tested it and it looks good now. With appreciation, Rohan. On 16/06/2015 5:13 pm, "Shlomi Fish via RT" <bug-Config-IniFiles@rt.cpan.org<mailto:bug-Config-IniFiles@rt.cpan.org>> wrote: <URL: https://rt.cpan.org/Ticket/Display.html?id=105255 > Hi Rohan, thanks for the report again. I investigated and fixed the problem in Config-IniFiles-2.87 which I just uploaded to CPAN. You may opt to visit my home site on the Web - http://www.shlomifish.org/ and see how to help it - http://www.shlomifish.org/meta/how-to-help/ . Thanks again! Marking as RESOLVED. Regards, -- Shlomi Fish On Tue Jun 16 04:21:21 2015, SHLOMIF wrote: On Tue Jun 16 03:59:50 2015, rohan@digins.net.au<mailto:rohan@digins.net.au> wrote: Show quoted text
> Dear maintainer, > > When I insert a comment containing a semicolon into an INI file, I was > surprised to see only half of it being treated as a comment, with the > reset being treated as part of the parameter value. > > Here is my test code: > > #!/usr/bin/env perl > use Config::IniFiles; > use warnings; > my $ini_file_contents = "[abc]\ndog=cat ; a comment ; further > comment"; > my $c = Config::IniFiles->new( > -file=>\$ini_file_contents, > -handle_trailing_comment=>1 > ); > print $c->val("abc","dog")."\n”; > > Expected output: cat > Actual output: cat ; a comment > > I tried this with version 2.86. > > I was hoping that you might be able to correct this behaviour. I note > that some other INI file parsers, such as crudini (command line util), > provide the result I expect. >
Hi Rohan, thanks for the report. I'll investigate and try to fix it. Regards, -- Shlomi Fish Show quoted text
> Thanks, > -- > Rohan Carly > >
-- Rohan Carly Digital Inscription Office: (08) 6102 6247 Mobile: 0419 041 246
content-type: text/html; charset="utf-8"
Content-Transfer-Encoding: base64
X-RT-Original-Encoding: utf-8
Content-ID: <FC08117015D609499EEC47D5AB8D52FE [...] apcprd02.prod.outlook.com>
Content-Length: 4030
MIME-Version: 1.0
In-Reply-To: <rt-4.0.18-3242-1434457614-564.105255-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <RT-Ticket-105255 [...] rt.cpan.org> <51DD9F5A-BAF3-4E5C-B470-DFFD0BCE1A36 [...] digins.net.au> <rt-4.0.18-9129-1434442881-625.105255-6-0 [...] rt.cpan.org> <rt-4.0.18-17954-1434445977-382.105255-6-0 [...] rt.cpan.org> <F95883C6-A00A-43E4-8A47-1722087AD45B [...] digins.net.au> <rt-4.0.18-3242-1434457614-564.105255-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.18-24314-1434479940-251.105255-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 329
Download (untitled) / with headers
text/plain 329b
Hi Rohan, On Tue Jun 16 08:26:54 2015, rohan@digins.net.au wrote: Show quoted text
> Hi Shlomi Fish, great work. > > I tested it and it looks good now. > > With appreciation, >
You're welcome. Thanks for the report! I also saw you sent me some money using PayPal - this is also appreciated. Thanks! ♥! Regards, -- Shlomi Fish Show quoted text
> Rohan.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.