Skip Menu |
 

This queue is for tickets about the Archive-Zip CPAN distribution.

Report information
The Basics
Id: 101374
Status: resolved
Priority: 0/
Queue: Archive-Zip

People
Owner: Nobody in particular
Requestors: zefram [...] fysh.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



MIME-Version: 1.0
X-Spam-Status: No, score=-2.137 tagged_above=-99.9 required=10 tests=[AWL=-0.226, BAYES_00=-1.9, SPF_HELO_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=ham
Content-Disposition: inline
X-Spam-Flag: NO
Content-Type: multipart/mixed; boundary="fdj2RfSjLxBAspz7"
Message-ID: <20150107140222.GA3081 [...] fysh.org>
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
X-Spam-Score: -2.137
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id 136AC24022B for <cpan-bug+Archive-Zip [...] hipster.bestpractical.com>; Wed, 7 Jan 2015 09:02:36 -0500 (EST)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VFtF9dcGyBGR for <cpan-bug+Archive-Zip [...] hipster.bestpractical.com>; Wed, 7 Jan 2015 09:02:35 -0500 (EST)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id ED0992401C8 for <bug-Archive-Zip [...] rt.cpan.org>; Wed, 7 Jan 2015 09:02:34 -0500 (EST)
Received: (qmail 15387 invoked by alias); 7 Jan 2015 14:02:33 -0000
Received: from river.fysh.org (HELO river.fysh.org) (5.135.154.127) by la.mx.develooper.com (qpsmtpd/0.28) with ESMTP; Wed, 07 Jan 2015 06:02:28 -0800
Received: from zefram by river.fysh.org with local (Exim 4.80 #2 (Debian)) id 1Y8rBm-0002zL-At; Wed, 07 Jan 2015 14:02:22 +0000
Delivered-To: cpan-bug+Archive-Zip [...] hipster.bestpractical.com
Subject: broken testZip autodetection
Return-Path: <zefram [...] fysh.org>
X-RT-Mail-Extension: archive-zip
X-Original-To: cpan-bug+Archive-Zip [...] hipster.bestpractical.com
X-Spam-Check-BY: la.mx.develooper.com
Date: Wed, 7 Jan 2015 14:02:22 +0000
X-Spam-Level:
To: bug-Archive-Zip [...] rt.cpan.org
From: Zefram <zefram [...] fysh.org>
X-RT-Interface: Email
Content-Length: 0
content-type: text/plain; charset="utf-8"
Content-Disposition: inline
X-RT-Original-Encoding: ascii
Content-Length: 189
Download (untitled) / with headers
text/plain 189b
If the unzip(1) program isn't available, Archive-Zip's test suite attempts to use it to test zip files, and so spuriously fails. The attached patch fixes the autodetection logic. -zefram
Content-Type: text/x-diff; charset="us-ascii"
Content-Disposition: attachment; filename="test_zip.patch"
X-RT-Original-Encoding: ascii
Content-Length: 731
Download test_zip.patch
text/x-diff 731b

Message body is not shown because sender requested not to inline it.

MIME-Version: 1.0
In-Reply-To: <20150107140222.GA3081 [...] fysh.org>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <20150107140222.GA3081 [...] fysh.org>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.18-17133-1420858035-1751.101374-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 52
Thanks, resolved with 1.41 which is enroute to CPAN.
MIME-Version: 1.0
In-Reply-To: <20150107140222.GA3081 [...] fysh.org>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <20150107140222.GA3081 [...] fysh.org>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.18-4531-1421022981-478.101374-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 145
Download (untitled) / with headers
text/plain 145b
Patch to this issue caused https://rt.cpan.org/Ticket/Display.html?id=101442 Please take a look and submit a new patch, have to revert this one.
CC: zefram [...] fysh.org, SMPETERS [...] cpan.org
MIME-Version: 1.0
X-Spam-Status: No, score=-4.135 tagged_above=-99.9 required=10 tests=[AWL=1.776, BAYES_00=-1.9, FROM_OUR_RT=-4, SPF_HELO_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=ham
In-Reply-To: <rt-4.0.18-4531-1421022981-513.101374-6-0 [...] rt.cpan.org>
Content-Disposition: inline
X-Spam-Flag: NO
X-RT-Interface: API
References: <RT-Ticket-101374 [...] rt.cpan.org> <20150107140222.GA3081 [...] fysh.org> <rt-4.0.18-4531-1421022981-513.101374-6-0 [...] rt.cpan.org>
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
Message-ID: <20150112120429.GB3081 [...] fysh.org>
content-type: text/plain; charset="utf-8"
X-RT-Original-Encoding: utf-8
X-Spam-Score: -4.135
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id 0682724032F for <cpan-bug+Archive-Zip [...] hipster.bestpractical.com>; Mon, 12 Jan 2015 07:04:53 -0500 (EST)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Ye2F4y-HM02Y for <cpan-bug+Archive-Zip [...] hipster.bestpractical.com>; Mon, 12 Jan 2015 07:04:47 -0500 (EST)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id C7463240220 for <bug-Archive-Zip [...] rt.cpan.org>; Mon, 12 Jan 2015 07:04:46 -0500 (EST)
Received: (qmail 29431 invoked by alias); 12 Jan 2015 12:04:45 -0000
Received: from river.fysh.org (HELO river.fysh.org) (5.135.154.127) by la.mx.develooper.com (qpsmtpd/0.28) with ESMTP; Mon, 12 Jan 2015 04:04:41 -0800
Received: from zefram by river.fysh.org with local (Exim 4.80 #2 (Debian)) id 1YAdjR-0002Lp-ES; Mon, 12 Jan 2015 12:04:29 +0000
Delivered-To: cpan-bug+Archive-Zip [...] hipster.bestpractical.com
Subject: Re: [rt.cpan.org #101374] broken testZip autodetection
Return-Path: <zefram [...] fysh.org>
X-Spam-Check-BY: la.mx.develooper.com
X-Original-To: cpan-bug+Archive-Zip [...] hipster.bestpractical.com
X-RT-Mail-Extension: archive-zip
Date: Mon, 12 Jan 2015 12:04:29 +0000
X-Spam-Level:
To: bug-Archive-Zip [...] rt.cpan.org
From: Zefram <zefram [...] fysh.org>
RT-Message-ID: <rt-4.0.18-22897-1421064293-1639.101374-0-0 [...] rt.cpan.org>
Content-Length: 856
Download (untitled) / with headers
text/plain 856b
Show quoted text
>Patch to this issue caused https://rt.cpan.org/Ticket/Display.html?id=101442 > >Please take a look and submit a new patch, have to revert this one.
Those errors do not appear to be caused by my patch. They appear to be genuine test failures, of a variety of types. The simplest type depends on choice of directory separator, which I'm quite sure my patch doesn't affect. Clearly you need to adjust those tests for Windows, and the fact that you didn't see the failures before implies that they weren't running on Windows before. So I think you have a bunch of tests that were being erroneously skipped before, and my patch has incidentally fixed the test suite to run them. This is probably down to the extraneous "local" that my patch removed. I haven't caused new faults; I've uncovered preexisting faults that were hidden by another bug. -zefram
MIME-Version: 1.0
X-Spam-Status: No, score=-5.886 tagged_above=-99.9 required=10 tests=[AWL=0.714, BAYES_00=-1.9, FROM_OUR_RT=-4, RCVD_IN_DNSWL_LOW=-0.7] autolearn=ham
In-Reply-To: <rt-4.0.18-22897-1421064293-414.101374-5-0 [...] rt.cpan.org>
X-Spam-Flag: NO
X-RT-Interface: API
References: <RT-Ticket-101374 [...] rt.cpan.org> <20150107140222.GA3081 [...] fysh.org> <rt-4.0.18-4531-1421022981-513.101374-6-0 [...] rt.cpan.org> <20150112120429.GB3081 [...] fysh.org> <rt-4.0.18-22897-1421064293-414.101374-5-0 [...] rt.cpan.org>
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
X-Received: by 10.112.130.65 with SMTP id oc1mr38299027lbb.7.1421086256375; Mon, 12 Jan 2015 10:10:56 -0800 (PST)
Message-ID: <CAHrynWAFm5YK-T+5M5w9QzD6E=ubpUAi=txz244bb8N5MLJTjw [...] mail.gmail.com>
content-type: text/plain; charset="utf-8"
X-RT-Original-Encoding: utf-8
X-Spam-Score: -5.886
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id E170B24016D for <cpan-bug+Archive-Zip [...] hipster.bestpractical.com>; Mon, 12 Jan 2015 13:11:08 -0500 (EST)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8yYQLIM7w-qa for <cpan-bug+Archive-Zip [...] hipster.bestpractical.com>; Mon, 12 Jan 2015 13:11:07 -0500 (EST)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id ECA6C240332 for <bug-Archive-Zip [...] rt.cpan.org>; Mon, 12 Jan 2015 13:11:06 -0500 (EST)
Received: (qmail 24702 invoked by alias); 12 Jan 2015 18:11:06 -0000
Received: from mail-lb0-f179.google.com (HELO mail-lb0-f179.google.com) (209.85.217.179) by la.mx.develooper.com (qpsmtpd/0.28) with ESMTP; Mon, 12 Jan 2015 10:11:02 -0800
Received: by mail-lb0-f179.google.com with SMTP id z11so18996002lbi.10 for <bug-Archive-Zip [...] rt.cpan.org>; Mon, 12 Jan 2015 10:10:56 -0800 (PST)
Received: by 10.25.158.65 with HTTP; Mon, 12 Jan 2015 10:10:56 -0800 (PST)
Delivered-To: cpan-bug+Archive-Zip [...] hipster.bestpractical.com
Subject: Re: [rt.cpan.org #101374] broken testZip autodetection
Return-Path: <fred [...] redhotpenguin.com>
X-Spam-Check-BY: la.mx.develooper.com
X-Original-To: cpan-bug+Archive-Zip [...] hipster.bestpractical.com
X-RT-Mail-Extension: archive-zip
X-Google-Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:content-type; bh=d9AWDryRO/iQvmOyFmSCUelTJcAmTFlbrOII2U8Lo0A=; b=ahMx47/27gflRNKArnCyWXI2hZt89pBSEoOm+BE83sOS1zX5BRzejxZp4JI6EgwAfJ U6aBoyHXeJ8nF9KxndMNp7etg+sYOQi6BgrD4i6A1fZov7z0ZSfqnR1WBYbYUKFc0gpc d4isgI8n+oBxHT6D63jrcKAQZbf09nPLU4+Kgv2ux6eiNVjJHhic79kKy4FXrXLCBqA/ v9U+KPwMOG3csKttKXPYIohocP+igVo1ymaJ2KTxIUF7wjeJ3t8H5Zcxzfd+iVNJwh/n bhBP64zzno0mF64yprbYQX3D3qpelFctjYaF8YJfCzPRsd4Sr/ppXGuMm3vbVFchNQIE h41Q==
Date: Mon, 12 Jan 2015 10:10:56 -0800
X-Spam-Level:
To: bug-Archive-Zip [...] rt.cpan.org
X-GM-Message-State: ALoCoQkov1tyF/3aqf2mRVYikwFyFVDYbI8B7PodXa4H8K3tUm4mJPclvzwo4vycYLvEty/xswx2
From: Fred Moyer <fred [...] redhotpenguin.com>
RT-Message-ID: <rt-4.0.18-30342-1421086269-1212.101374-0-0 [...] rt.cpan.org>
Content-Length: 1186
Download (untitled) / with headers
text/plain 1.1k
Ok I'll take another look at this tonight and reapply. Maybe I can get a windows CI environment hooked up somehow. On Mon, Jan 12, 2015 at 4:04 AM, Zefram via RT <bug-Archive-Zip@rt.cpan.org> wrote: Show quoted text
> Queue: Archive-Zip > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=101374 > >
>>Patch to this issue caused https://rt.cpan.org/Ticket/Display.html?id=101442 >> >>Please take a look and submit a new patch, have to revert this one.
> > Those errors do not appear to be caused by my patch. They appear to > be genuine test failures, of a variety of types. The simplest type > depends on choice of directory separator, which I'm quite sure my patch > doesn't affect. Clearly you need to adjust those tests for Windows, > and the fact that you didn't see the failures before implies that they > weren't running on Windows before. > > So I think you have a bunch of tests that were being erroneously skipped > before, and my patch has incidentally fixed the test suite to run them. > This is probably down to the extraneous "local" that my patch removed. > I haven't caused new faults; I've uncovered preexisting faults that were > hidden by another bug. > > -zefram >
MIME-Version: 1.0
X-Spam-Status: No, score=-5.933 tagged_above=-99.9 required=10 tests=[AWL=0.667, BAYES_00=-1.9, FROM_OUR_RT=-4, RCVD_IN_DNSWL_LOW=-0.7] autolearn=ham
In-Reply-To: <rt-4.0.18-30342-1421086269-719.101374-5-0 [...] rt.cpan.org>
X-Spam-Flag: NO
X-RT-Interface: API
References: <RT-Ticket-101374 [...] rt.cpan.org> <20150107140222.GA3081 [...] fysh.org> <rt-4.0.18-4531-1421022981-513.101374-6-0 [...] rt.cpan.org> <20150112120429.GB3081 [...] fysh.org> <rt-4.0.18-22897-1421064293-414.101374-5-0 [...] rt.cpan.org> <CAHrynWAFm5YK-T+5M5w9QzD6E=ubpUAi=txz244bb8N5MLJTjw [...] mail.gmail.com> <rt-4.0.18-30342-1421086269-719.101374-5-0 [...] rt.cpan.org>
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
X-Received: by 10.152.42.198 with SMTP id q6mr39313508lal.48.1421130754900; Mon, 12 Jan 2015 22:32:34 -0800 (PST)
Message-ID: <CAHrynWCep2vfwBwU-39uWBrXo9UVNboxsaw933w4aj2UZwzEXQ [...] mail.gmail.com>
content-type: text/plain; charset="utf-8"
X-RT-Original-Encoding: utf-8
X-Spam-Score: -5.933
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id E793224032F for <cpan-bug+Archive-Zip [...] hipster.bestpractical.com>; Tue, 13 Jan 2015 01:32:43 -0500 (EST)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1ha3wEBgO0-M for <cpan-bug+Archive-Zip [...] hipster.bestpractical.com>; Tue, 13 Jan 2015 01:32:42 -0500 (EST)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id 9CFEE240220 for <bug-Archive-Zip [...] rt.cpan.org>; Tue, 13 Jan 2015 01:32:42 -0500 (EST)
Received: (qmail 3091 invoked by alias); 13 Jan 2015 06:32:42 -0000
Received: from mail-lb0-f172.google.com (HELO mail-lb0-f172.google.com) (209.85.217.172) by la.mx.develooper.com (qpsmtpd/0.28) with ESMTP; Mon, 12 Jan 2015 22:32:39 -0800
Received: by mail-lb0-f172.google.com with SMTP id z12so981467lbi.3 for <bug-Archive-Zip [...] rt.cpan.org>; Mon, 12 Jan 2015 22:32:35 -0800 (PST)
Received: by 10.25.158.65 with HTTP; Mon, 12 Jan 2015 22:32:34 -0800 (PST)
Delivered-To: cpan-bug+Archive-Zip [...] hipster.bestpractical.com
Subject: Re: [rt.cpan.org #101374] broken testZip autodetection
Return-Path: <fred [...] redhotpenguin.com>
X-Spam-Check-BY: la.mx.develooper.com
X-Original-To: cpan-bug+Archive-Zip [...] hipster.bestpractical.com
X-RT-Mail-Extension: archive-zip
X-Google-Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:content-type; bh=K/rrBkZtZNKXMXahvCmpCZojP5t9I2aW/jjrOPJ8pto=; b=de9CJVLVpd4TJRFoG4iQOUCPy+spNqTKHupjO/GhPcE6vffSKLab8cuxGDJmgioECa xVDCT3adUbF1qZBljz34PiiceLBFRPG4Spox6Xa/j2rkwF8lu6VFqs8HoADbiRrGcuxK ML0j0cdVekjK+OHsGs5JGeEBXqA4rcckxP7eiqlaU9Dk64pdfCwWHOvkHRdRUNpRpCEs 8berU8iXa87iE0GshyWl7b99KXb5sJO+1RJwfD8ILpqB4wqKZhLCv5zBcBBi0ZpMStie mtq+NBHiLObLpqRr7mrL5Kik/3LpfqvMbj3eLVX/NnygLGbxA6uNYZXYrlmlz0qW1VYE wWxQ==
Date: Mon, 12 Jan 2015 22:32:34 -0800
X-Spam-Level:
To: bug-Archive-Zip [...] rt.cpan.org
X-GM-Message-State: ALoCoQmQilCbqQ3K99xj/y7MHazZFw3VK9nEldhd7rErg4TU5783NCBkmjpS8cQ4AQk8Qo48r21Z
From: Fred Moyer <fred [...] redhotpenguin.com>
RT-Message-ID: <rt-4.0.18-32707-1421130764-313.101374-0-0 [...] rt.cpan.org>
Content-Length: 1540
Download (untitled) / with headers
text/plain 1.5k
I pushed this change back on github. Will check cpantester reports when the machine is back up, should be a couple days. On Mon, Jan 12, 2015 at 10:11 AM, fred@redhotpenguin.com via RT <bug-Archive-Zip@rt.cpan.org> wrote: Show quoted text
> Queue: Archive-Zip > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=101374 > > > Ok I'll take another look at this tonight and reapply. Maybe I can get > a windows CI environment hooked up somehow. > > On Mon, Jan 12, 2015 at 4:04 AM, Zefram via RT > <bug-Archive-Zip@rt.cpan.org> wrote:
>> Queue: Archive-Zip >> Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=101374 > >>
>>>Patch to this issue caused https://rt.cpan.org/Ticket/Display.html?id=101442 >>> >>>Please take a look and submit a new patch, have to revert this one.
>> >> Those errors do not appear to be caused by my patch. They appear to >> be genuine test failures, of a variety of types. The simplest type >> depends on choice of directory separator, which I'm quite sure my patch >> doesn't affect. Clearly you need to adjust those tests for Windows, >> and the fact that you didn't see the failures before implies that they >> weren't running on Windows before. >> >> So I think you have a bunch of tests that were being erroneously skipped >> before, and my patch has incidentally fixed the test suite to run them. >> This is probably down to the extraneous "local" that my patch removed. >> I haven't caused new faults; I've uncovered preexisting faults that were >> hidden by another bug. >> >> -zefram >>
>
MIME-Version: 1.0
In-Reply-To: <rt-4.0.18-32707-1421130764-313.101374-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <RT-Ticket-101374 [...] rt.cpan.org> <20150107140222.GA3081 [...] fysh.org> <rt-4.0.18-4531-1421022981-513.101374-6-0 [...] rt.cpan.org> <20150112120429.GB3081 [...] fysh.org> <rt-4.0.18-22897-1421064293-414.101374-5-0 [...] rt.cpan.org> <CAHrynWAFm5YK-T+5M5w9QzD6E=ubpUAi=txz244bb8N5MLJTjw [...] mail.gmail.com> <rt-4.0.18-30342-1421086269-719.101374-5-0 [...] rt.cpan.org> <CAHrynWCep2vfwBwU-39uWBrXo9UVNboxsaw933w4aj2UZwzEXQ [...] mail.gmail.com> <rt-4.0.18-32707-1421130764-313.101374-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.18-8495-1421300085-401.101374-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 302
Download (untitled) / with headers
text/plain 302b
Without this change I cannot install 1.42, linux 5.20.1, but can install 1.41. Installing unzip allowed me to install 1.42. I could not install 1.40 either but could 1.39. On windows, strawberry perl same version, I cannot install anything newer than 1.38, which is also shipped with the distribution.
MIME-Version: 1.0
In-Reply-To: <20150107140222.GA3081 [...] fysh.org>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <20150107140222.GA3081 [...] fysh.org>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.18-5021-1421303823-1120.101374-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 104
Download (untitled) / with headers
text/plain 104b
Ok 1.43 is up on CPAN with this change. Will keep an eye on cpantesters to see if there are any effects.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.