Bug #100946 for Finance-Bank-Bankwest: transaction search dates not being honoured
This queue is for tickets about the Finance-Bank-Bankwest CPAN distribution.
Maintainer(s)' notes
This distribution provides the ability to log into Bankwest's Online Banking service using a Personal Access Number (PAN) and access code, then retrieve information on all accounts associated with that PAN and their transactions.
Report information
The Basics
People
Owner:
lxp [...] cpan.org
Requestors:
owenhollands [...] gmail.com
Cc:
AdminCc:
BugTracker
Severity:
(no value)
Broken in:
1.2.8
Fixed in:
(no value)
Attachments
Session-fix.diff
Tue Dec 16 07:02:10 2014
lxp [...] cpan.org - Reference by #93739: cannot create Transaction instances without a transaction code added
| MIME-Version: | 1.0 |
| In-Reply-To: | <rt-4.0.18-14927-1418731206-1704.0-0-0@rt.cpan.org> |
| X-Mailer: | MIME-tools 5.504 (Entity 5.504) |
| Content-Disposition: | inline |
| X-RT-Interface: | Web |
| References: | <rt-4.0.18-14927-1418731206-1704.0-0-0@rt.cpan.org> |
| Content-Type: | text/plain; charset="utf-8" |
| Message-ID: | <rt-4.0.18-7215-1418731652-1904.100946-0-0@rt.cpan.org> |
| Content-Transfer-Encoding: | binary |
| X-RT-Original-Encoding: | utf-8 |
| X-RT-Encrypt: | 0 |
| X-RT-Sign: | 0 |
| Content-Length: | 421 |
Hi Owen,
On Tue Dec 16 11:12:01 2014, owenhollands@gmail.com wrote:
Show quoted text
> I was wondering if you had experienced an issue where queries return
> the last 7 days of transactions, regardless of the dates specified?
Thanks for letting me know about this. Bankwest's Transaction Search
form parameters have changed, so an update to Finance::Bank::Bankwest is
needed. I'll release a fix shortly.
--
Kind regards,
Alex Peters
| MIME-Version: | 1.0 |
| In-Reply-To: | <rt-4.0.18-7215-1418731652-1904.100946-0-0@rt.cpan.org> |
| X-Mailer: | MIME-tools 5.504 (Entity 5.504) |
| X-RT-Interface: | Web |
| References: | <rt-4.0.18-14927-1418731206-1704.0-0-0@rt.cpan.org> <rt-4.0.18-7215-1418731652-1904.100946-0-0@rt.cpan.org> |
| Content-Type: | multipart/mixed; boundary="----------=_1418821894-31519-6" |
| Message-ID: | <rt-4.0.18-31519-1418821894-1926.100946-0-0@rt.cpan.org> |
| X-RT-Original-Encoding: | utf-8 |
| X-RT-Encrypt: | 0 |
| X-RT-Sign: | 0 |
| Content-Length: | 0 |
| Content-Disposition: | inline |
| Content-Type: | text/plain; charset="utf-8" |
| Content-Transfer-Encoding: | binary |
| X-RT-Original-Encoding: | utf-8 |
| Content-Length: | 647 |
Hi Owen,
On Tue Dec 16 23:07:32 2014, LXP wrote:
Show quoted text
> Bankwest's Transaction Search form parameters have changed, so an
> update to Finance::Bank::Bankwest is needed. I'll release a fix
> shortly.
I've identified the necessary fix, but I don't want to release until
I've updated the unit tests (which will require me downloading a bunch
of new HTML from Bankwest).
In the meantime, if you'd like a fix urgently, the attached patch
(prepared against the source on GitHub) shows how to manually modify Finance/Bank/Bankwest/Session.pm for correct operation.
I'll let you know when the fix has been properly released.
--
Kind regards,
Alex Peters
| MIME-Version: | 1.0 |
| Subject: | Session-fix.diff |
| X-Mailer: | MIME-tools 5.504 (Entity 5.504) |
| Content-Type: | text/x-patch; name="Session-fix.diff" |
| Content-Disposition: | inline; filename="Session-fix.diff" |
| Content-Transfer-Encoding: | binary |
| Content-Length: | 607 |
diff --git a/lib/Finance/Bank/Bankwest/Session.pm b/lib/Finance/Bank/Bankwest/Session.pm
index 12b66e0..53d8df1 100644
--- a/lib/Finance/Bank/Bankwest/Session.pm
+++ b/lib/Finance/Bank/Bankwest/Session.pm
@@ -224,6 +224,8 @@ date of the following Monday.
=> '3~4~5~6~7',
'_ctl0:ContentMain:ddlAccount'
=> $account,
+ '_ctl0:ContentMain:ddlRangeOptions'
+ => 'CUSTOM',
'_ctl0:ContentMain:dpFromDate:txtDate'
=> $from_date,
'_ctl0:ContentMain:dpToDate:txtDate'
| MIME-Version: | 1.0 |
| X-Spam-Status: | No, score=-5.198 tagged_above=-99.9 required=10 tests=[AWL=1.500, BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, FROM_OUR_RT=-4, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=ham |
| In-Reply-To: | <rt-4.0.18-31519-1418821894-431.100946-6-0@rt.cpan.org> |
| X-Spam-Flag: | NO |
| X-RT-Interface: | API |
| References: | <RT-Ticket-100946@rt.cpan.org> <rt-4.0.18-14927-1418731206-1704.100946-6-0@rt.cpan.org> <rt-4.0.18-7215-1418731652-1904.100946-6-0@rt.cpan.org> <rt-4.0.18-31519-1418821894-431.100946-6-0@rt.cpan.org> |
| X-Virus-Scanned: | Debian amavisd-new at bestpractical.com |
| X-Received: | by 10.50.3.99 with SMTP id b3mr94844igb.9.1418865213658; Wed, 17 Dec 2014 17:13:33 -0800 (PST) |
| Reply-To: | owenhollands@gmail.com |
| Message-ID: | <CAJ7OPk43F-7jjD=feD4e055LQ995WiX9FvG+v7LUaf=us9DXeg@mail.gmail.com> |
| Content-Type: | multipart/alternative; boundary="089e0129449c0b5bf5050a734de9" |
| X-Spam-Score: | -5.198 |
| Authentication-Results: | hipster.bestpractical.com (amavisd-new); dkim=pass header.i=@gmail.com |
| Received: | from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id A5AC1240640 for <cpan-bug+Finance-Bank-Bankwest@hipster.bestpractical.com>; Wed, 17 Dec 2014 20:13:43 -0500 (EST) |
| Received: | from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Q4a61IXST9uZ for <cpan-bug+Finance-Bank-Bankwest@hipster.bestpractical.com>; Wed, 17 Dec 2014 20:13:42 -0500 (EST) |
| Received: | from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id 3A9742402E9 for <bug-Finance-Bank-Bankwest@rt.cpan.org>; Wed, 17 Dec 2014 20:13:42 -0500 (EST) |
| Received: | (qmail 29860 invoked by alias); 18 Dec 2014 01:13:41 -0000 |
| Received: | from mail-ig0-f178.google.com (HELO mail-ig0-f178.google.com) (209.85.213.178) by la.mx.develooper.com (qpsmtpd/0.28) with ESMTP; Wed, 17 Dec 2014 17:13:37 -0800 |
| Received: | by mail-ig0-f178.google.com with SMTP id hl2so89369igb.5 for <bug-Finance-Bank-Bankwest@rt.cpan.org>; Wed, 17 Dec 2014 17:13:33 -0800 (PST) |
| Received: | by 10.64.118.198 with HTTP; Wed, 17 Dec 2014 17:13:33 -0800 (PST) |
| Delivered-To: | cpan-bug+Finance-Bank-Bankwest@hipster.bestpractical.com |
| Subject: | Re: [rt.cpan.org #100946] transaction search dates not being honoured |
| Return-Path: | <owenhollands@gmail.com> |
| Dkim-Signature: | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:in-reply-to:references:date:message-id :subject:from:to:content-type; bh=qPADm7RiCj3UGByLR01zQQDhJ30LyVPUO02ZnTjdmOE=; b=sop+R3l3pMXNqaQeHigwqjzCRJzNHkyNyL47et1/IcbvzExvcrR8Y3jW9jixPp0UN9 wP1AYzEo2Ui+t+jBzz4ml6VeeE3a5X5B40t5Ls98OC4gqeEwpSSxRd8OJnIBuQVYh5CO xfQLiyjxVs+f/haTNiKfyV69zAGvwDQzfQ4RZfaNHuPNCaADj1e31abb0xqa4kXr7lv2 uniLw/Gj+jb078kmubd1UHygw/nYiigd6JNVEp1U/zTGr91N3StvmajmKWSnFBVsZ/EV msSHhZ3laeA0LWzCeKk+vv7Y7ii807satv4BAmr4X0cTTM0+mqv2F0hO5hoDAPBg1sJ5 6TFg== |
| X-Spam-Check-BY: | la.mx.develooper.com |
| X-Original-To: | cpan-bug+Finance-Bank-Bankwest@hipster.bestpractical.com |
| X-RT-Mail-Extension: | finance-bank-bankwest |
| Date: | Thu, 18 Dec 2014 12:13:33 +1100 |
| X-Spam-Level: | |
| To: | bug-Finance-Bank-Bankwest@rt.cpan.org |
| From: | Owen Hollands <owenhollands@gmail.com> |
| RT-Message-ID: | <rt-4.0.18-10372-1418865224-1327.100946-0-0@rt.cpan.org> |
| Content-Length: | 0 |
| content-type: | text/plain; charset="utf-8" |
| X-RT-Original-Encoding: | utf-8 |
| Content-Length: | 1765 |
| content-type: | text/html; charset="utf-8" |
| Content-Transfer-Encoding: | quoted-printable |
| X-RT-Original-Encoding: | utf-8 |
| Content-Length: | 2542 |
That seems to be working - thanks. You saved my a bunch of time trying to fix that.
As an asside, do you think there is value in a check script that compares the HTML off the bankwest website with a reference copy to try and detect of the website ahs been updated?
Owen.
On Thu, Dec 18, 2014 at 12:11 AM, Alex Peters via RT <bug-Finance-Bank-Bankwest@rt.cpan.org> wrote:
Show quoted text
<URL: https://rt.cpan.org/Ticket/Display.html?id=100946 >
Hi Owen,
On Tue Dec 16 23:07:32 2014, LXP wrote:
> Bankwest's Transaction Search form parameters have changed, so an
> update to Finance::Bank::Bankwest is needed. I'll release a fix
> shortly.
I've identified the necessary fix, but I don't want to release until
I've updated the unit tests (which will require me downloading a bunch
of new HTML from Bankwest).
In the meantime, if you'd like a fix urgently, the attached patch
(prepared against the source on GitHub) shows how to manually modify Finance/Bank/Bankwest/Session.pm for correct operation.
I'll let you know when the fix has been properly released.
--
Kind regards,
Alex Peters
diff --git a/lib/Finance/Bank/Bankwest/Session.pm b/lib/Finance/Bank/Bankwest/Session.pm
index 12b66e0..53d8df1 100644
--- a/lib/Finance/Bank/Bankwest/Session.pm
+++ b/lib/Finance/Bank/Bankwest/Session.pm
@@ -224,6 +224,8 @@ date of the following Monday.
=> '3~4~5~6~7',
'_ctl0:ContentMain:ddlAccount'
=> $account,
+ '_ctl0:ContentMain:ddlRangeOptions'
+ => 'CUSTOM',
'_ctl0:ContentMain:dpFromDate:txtDate'
=> $from_date,
'_ctl0:ContentMain:dpToDate:txtDate'
| MIME-Version: | 1.0 |
| In-Reply-To: | <rt-4.0.18-10372-1418865224-1327.100946-0-0@rt.cpan.org> |
| X-Mailer: | MIME-tools 5.504 (Entity 5.504) |
| Content-Disposition: | inline |
| X-RT-Interface: | Web |
| References: | <RT-Ticket-100946@rt.cpan.org> <rt-4.0.18-14927-1418731206-1704.100946-6-0@rt.cpan.org> <rt-4.0.18-7215-1418731652-1904.100946-6-0@rt.cpan.org> <rt-4.0.18-31519-1418821894-431.100946-6-0@rt.cpan.org> <CAJ7OPk43F-7jjD=feD4e055LQ995WiX9FvG+v7LUaf=us9DXeg@mail.gmail.com> <rt-4.0.18-10372-1418865224-1327.100946-0-0@rt.cpan.org> |
| Content-Type: | text/plain; charset="utf-8" |
| Message-ID: | <rt-4.0.18-20608-1418900082-661.100946-0-0@rt.cpan.org> |
| Content-Transfer-Encoding: | binary |
| X-RT-Original-Encoding: | utf-8 |
| X-RT-Encrypt: | 0 |
| X-RT-Sign: | 0 |
| Content-Length: | 1764 |
Hi Owen,
On Thu Dec 18 12:13:44 2014, owenhollands@gmail.com wrote:
Show quoted text
> As an asside, do you think there is value in a check script that
> compares the HTML off the bankwest website with a reference copy to
> try and detect of the website ahs been updated?
I suppose it would be a bit complicated to directly compare live website
data to a reference copy, because of the varying tokens, account info,
etc. found on every page.
On that basis, I would probably go about this by scripting a bunch of
actions on the Bankwest website, passing the resultant HTML to the
Finance::Bank::Bankwest::Parser modules, and then testing that they
don't reject the HTML.
That alone, though, probably wouldn't achieve anything more than just
regularly using the Finance::Bank::Bankwest distribution normally.
I've tried to code those parser modules with enough expectations that
they fail quite verbosely if Bankwest significantly alters the
construction of its responses, but with enough leniency that minor
design changes would allow the code to continue to work. It seems to be
a difficult balance to get right.
The parsers continued to work in this case because the change Bankwest
made was extremely subtle: take a <select> box which was previously
optional, add a new <option> and require that <option> to be selected
for the date fields not to be ignored. As far as the relevant parser
was concerned, it was exactly the same page.
In short, I'm not against the idea of some sort of check script, but I'm
struggling to picture how a useful one would operate and whether it
would really result in fewer breakages. I'm definitely open to further
discussion and insight on the matter though. Thanks for the idea; I'll
keep thinking on it.
--
Kind regards,
Alex Peters
This service runs on Request Tracker, is sponsored by The Perl Foundation, and maintained by Best Practical Solutions.
Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.
Time to display: 0.410365 - RT Version 5.0.1
Copyright 1996-2021 »|« Best Practical Solutions, LLC.