#33926: Test::Simple breaks ExtUtils::Command

Andreas Koenig via RT wrote:
> I hope Schwern will tell us who'se blame it is. In any case I observe a
> broken ExtUtils::Command test with Test::Simple 0.78. Downgrading to
> 0.75 fixes it again.
>
> Schwern's recent posting to use.perl.org may be related.
>
> Schwern?

The bug fix in Test::More fixed in 0.77 revealed a bug in ExtUtils::Command.
http://www.nntp.perl.org/group/perl.qa/2008/03/msg10460.html

*CORE::GLOBAL::exit = sub {
CORE::exit(@_) unless caller eq 'ExtUtils::Command';

my $exit = $_[0] || 0;
die "exit: $exit\n";
};

exit() has a prototype of ;$ so it interprets @_ in scalar context. If you
give it an argument it exits with 1. The test is now failing correctly.


--
I am somewhat preoccupied telling the laws of physics to shut up and sit down.
-- Vaarsuvius, "Order of the Stick"
http://www.giantitp.com/comics/oots0107.html

On Mon Mar 10 02:21:21 2008, schwern[...]pobox.com wrote:
> Andreas Koenig via RT wrote:
> > I hope Schwern will tell us who'se blame it is. In any case I observe a
> > broken ExtUtils::Command test with Test::Simple 0.78. Downgrading to
> > 0.75 fixes it again.
> >
> > Schwern's recent posting to use.perl.org may be related.
> >
> > Schwern?
>
> The bug fix in Test::More fixed in 0.77 revealed a bug in
ExtUtils::Command.
> http://www.nntp.perl.org/group/perl.qa/2008/03/msg10460.html
>
> *CORE::GLOBAL::exit = sub {
> CORE::exit(@_) unless caller eq 'ExtUtils::Command';
>
> my $exit = $_[0] || 0;
> die "exit: $exit\n";
> };
>
> exit() has a prototype of ;$ so it interprets @_ in scalar context.
If you
> give it an argument it exits with 1. The test is now failing correctly.
>

Does this suggest the following patch to Shell::Command?

===================================================================
--- Command.pm (revision 10908)
+++ Command.pm (working copy)
@@ -6,7 +6,7 @@
# takes effect.
BEGIN {
*CORE::GLOBAL::exit = sub {
- CORE::exit(@_) unless caller eq 'ExtUtils::Command';
+ CORE::exit($_[0]) unless caller eq 'ExtUtils::Command';

my $exit = $_[0] || 0;
die "exit: $exit\n";


With this, the shell_exit test passes for both Test::Simple version 0.78
and earlier versions.

On Wed Mar 12 10:26:40 2008, schwern[...]pobox.com wrote:
> RKOBES via RT wrote:
> >> exit() has a prototype of ;$ so it interprets @_ in scalar context.
> > If you
> >> give it an argument it exits with 1. The test is now failing
correctly.
> >
> > Does this suggest the following patch to Shell::Command?
>
> Yep.
>
>
> > ===================================================================
> > --- Command.pm (revision 10908)
> > +++ Command.pm (working copy)
> > @@ -6,7 +6,7 @@
> > # takes effect.
> > BEGIN {
> > *CORE::GLOBAL::exit = sub {
> > - CORE::exit(@_) unless caller eq 'ExtUtils::Command';
> > + CORE::exit($_[0]) unless caller eq 'ExtUtils::Command';
> >
> > my $exit = $_[0] || 0;
> > die "exit: $exit\n";
> >
> >
> > With this, the shell_exit test passes for both Test::Simple version 0.78
> > and earlier versions.

Thanks very much, and also thanks for tracking this down. This is fixed
in ExtUtils-Command-1.14, which will be on CPAN shortly.