#29374: Documentation shows a bad example.

Here is a test case that breaks the $dir->children()

[11:52am]/home/daniel/t>cat go.pl
use Path::Class;

my $dir = Path::Class::dir('.');
print join ', ', $dir->children();
print "\n";

[11:52am]/home/daniel/t>ls -al
total 6
drwxr-xr-x 2 daniel staff 512 Sep 14 11:51 .
drwxr-xr-x 8 daniel staff 512 Sep 14 11:49 ..
-rw-r--r-- 1 daniel staff 0 Sep 14 11:51 0
-rw-r--r-- 1 daniel staff 0 Sep 14 11:51 1
-rw-r--r-- 1 daniel staff 0 Sep 14 11:51 2
-rw-r--r-- 1 daniel staff 0 Sep 14 11:51 3
-rw-r--r-- 1 daniel staff 0 Sep 14 11:51 4
-rw-r--r-- 1 daniel staff 0 Sep 14 11:51 5
-rw-r--r-- 1 daniel staff 99 Sep 14 11:51 go.pl
[11:52am]/home/daniel/t>perl go.pl
./go.pl, ./1, ./2, ./3
[11:52am]/home/daniel/t>


files are created by
touch 1
touch 2
touch 3
touch 0
touch 4
touch 5

Actually $file won't be "0" it'll be "$dir/0" or the platform equivalent, which is non-false.

-Ken

I need to include test cases for my own thoughts :).

The problem is in the while loop condition check, the return scalar
value of the IO::Dir->read (readdir). The code exits before Path::Class
has a chance to stringify it.

The while loop receives a scalar value from $handle (IO::Dir), which in
the case of a file or directory that is a name of "0" (zero) it
evaluates to false and the loop is terminated.

I've included a test case below:

use Path::Class;
use Path::Class::Dir;

mkdir '1';
mkdir '0';

my $dir=dir('.');

my $handle = $dir->open;

# while ( defined ( my $file = $handle->read ) ) { # this works.
while ( my $file = $handle->read ) { # IO::Dir->read returns a scalar value
print "1: ", $file, "\n";
$file = $dir->file($file); # Turn $file into Path::Class::File object
print "2: ", $file, "\n";
print "\n";
}

# clean up after ourself.
rmdir '1';
rmdir '0';