Skip Menu | You are currently an anonymous guest. | Login | Return to Main | About rt.cpan.org
 

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.

X Report information
Id: 29049
Status: resolved
Left: 0 min
Priority: 0/0
Queue: Jcode

Owner: Nobody
Requestors: ISLUE <islue [...] cpan.org>
Cc:
AdminCc:

Severity: Important
Broken in: 2.06
Fixed in: (no value)




X History Display mode: Brief headersFull headers
#   Wed Aug 29 12:38:44 2007 ISLUE - Ticket created  
Subject: mime_encode doesn't work properly
[text/plain 337b]
I tried to fix the following problems.

1. According to RFC1522 as the document mentioned, I'm afraid it would
be better to set $lf as \r\n instead of \n, which could cause some MTA
like qmail working improperly.

2. The optional parameter $lf is not used in the function, although the
document says it is.
--
http://islue.blogspot.com/
Subject: patch.txt

[text/plain 767b]
Common subdirectories: Jcode-2.06.orig/Jcode and Jcode-2.06/Jcode
diff Jcode-2.06.orig/Jcode.pm Jcode-2.06/Jcode.pm
414c414
< my $lf = shift || "\n";
---
> my $lf = shift || "\r\n";
429c429
< my($str, $line, $bpl) = @_;
---
> my($str, $line, $lf, $bpl) = @_;
436c436
< $line =~ s/[ \t\n\r]*$/\n/;
---
> $line =~ s/[ \t\n\r]*$/$lf/eo;
486c486
< $header = _add_encoded_word($word, $header, $bpl);
---
> $header = _add_encoded_word($word, $header, $lf, $bpl);
727c727
< When $lf is specified, it uses $lf to fold line (default: \n).
---
> When $lf is specified, it uses $lf to fold line (default: \r\n).
Common subdirectories: Jcode-2.06.orig/Unicode and Jcode-2.06/Unicode
Common subdirectories: Jcode-2.06.orig/t and Jcode-2.06/t

#   Sat May 10 14:21:18 2008 DANKOGAI - Correspondence added  
[text/plain 628b]
Thank you for your patch and sorry for not responding soon.
Patch is applied though $lf default value remains \n for backward compatibility and other
MTAs that expect \n.

Newer version is now available at http://openlab.jp/Jcode/

Dan the Maintainer Thereof

On Wed Aug 29 12:38:44 2007, ISLUE wrote:
> I tried to fix the following problems.
>
> 1. According to RFC1522 as the document mentioned, I'm afraid it would
> be better to set $lf as \r\n instead of \n, which could cause some MTA
> like qmail working improperly.
>
> 2. The optional parameter $lf is not used in the function, although the
> document says it is.



#   Sat May 10 14:21:20 2008 RT_System - Status changed from 'new' to 'open'  
#   Sat May 10 14:21:21 2008 DANKOGAI - Status changed from 'open' to 'resolved'