Skip Menu | You are currently an anonymous guest. | Login | Return to Main | About rt.cpan.org
 

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.

X Report information
Id: 25760
Status: resolved
Left: 0 min
Priority: 0/0
Queue: Net-Delicious

Owner: Nobody
Requestors: RJBS <rjbs [...] cpan.org>
Cc:
AdminCc:

Severity: Important
Broken in: (no value)
Fixed in: (no value)



X History Display mode: Brief headersFull headers
#   Sat Mar 24 18:29:08 2007 RJBS - Ticket created  
Subject: can't override update cache location
[text/plain 537b]
This took me too long to figure out... the documentation for "updates"
is slightly confusing. It says:

Default is the current user's home directory, followed by a temporary
directory as determined by File::Temp.

I thought it means "the homedir, catdir'd with another..."

...but that is not the problem. The problem I think is this code in
Delicious.pm:

if ((exists($self->{'__updates'})) && (-d $self->{'__updated'})) {
$root = $self->{'__updates'};
}

The second hash lookup should be __updates, not __updated.

--
rjbs
#   Sun Mar 25 12:25:14 2007 ASCOPE - Correspondence added  
[text/plain 227b]
Urg. My bad.

Version 1.11 is on its way to the CPAN. In the meantime you can grab a copy over here :

http://aaronland.info/perl/net/delicious/Net-Delicious-1.11.tar.gz
http://aaronland.info/perl/net/delicious/Changes

Cheers,
#   Sun Mar 25 12:25:15 2007 RT_System - Status changed from 'new' to 'open'  
#   Sun Mar 25 12:25:16 2007 ASCOPE - Status changed from 'open' to 'resolved'  
#   Sun Mar 25 21:34:49 2007 RJBS - Correspondence added  
[text/plain 425b]
I am not sure if this is really fixed; it seems to be, but look at line
1030 versus 1009. The "$root" lexical is declared twice in the same
scope. It looks like you could nuke any reference to it and just put
$self->{__updates} in the catfile call.

This turned up because I ran this module with warnings. Do you support
5.5? If not, using warnings in Net::Delicious would have found this
during normal testing.

--
rjbs
#   Sun Mar 25 21:34:50 2007 RT_System - Status changed from 'resolved' to 'open'  
#   Thu Feb 28 03:50:03 2008 ANDREMAR - Correspondence added  
[text/plain 230b]
Any status on this? It should be an easy fix, and the warning is quite
anoying in the production logs

"my" variable $root masks earlier declaration in same scope at
/opt/local/lib/perl5/site_perl/5.8.8/Net/Delicious.pm line 1030.
#   Mon Mar 03 11:45:43 2008 ASCOPE - Correspondence added  
[text/plain 164b]
Fixed in N:D 1.13 which is on it's way to the CPAN. In the meantime, you
can grab a copy here :

http://aaronland.info/perl/net/delicious/Net-Delicious-1.13.tar.gz
#   Mon Mar 03 11:45:45 2008 ASCOPE - Status changed from 'open' to 'resolved'