#19524: t/test.t fails if DNS is not available

#

Sat May 27 10:15:39 2006

FLORA - Ticket created

[text/plain 755b]

Hello Achim,

I'm the Debian maintainer of GSSAPI and recently recieved a bug report
for that package:

http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=367377

The submitter complains that the modules tests will fail while being
offline, as some of them require network access.

I'd like to keep running the tests at build time and consider SKIPing
some of the tests in the Debian package as a bit unclean. Therefor I'd
like to ask you to integrate a clean solution for the problem in your
modules test suite.

I'd suggest to either skip all tests that require networking unless some
condition is met, for example if $ENV{TEST_ONLINE} is set, or to be
smarter and try to detect if a network connection is available when
running the test suite.

TIA,
Flo

#

Sat May 27 11:13:22 2006

achim[...]grolmsnet.de - Correspondence added

CC:	bug-GSSAPI[...]rt.cpan.org, perlgssapi-developer[...]lists.sourceforge.net, Daniel Schepler <schepler[...]math.berkeley.edu>
Subject:	Re: [rt.cpan.org #19524]
Date:	Sat, 27 May 2006 17:12:12 +0200
To:	rafl[...]debian.org
From:	Achim Grolms <achim[...]grolmsnet.de>

[text/plain 1k]

On Saturday 27 May 2006 16:15, Florian Ragwitz via RT wrote:

> Sat May 27 10:15:39 2006: Request 19524 was acted upon.
> Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=19524 >

Thank you for sending the bugreport!

> The submitter complains that the modules tests will fail while being
> offline, as some of them require network access.

I've checked this, he is right.
I get the same fails after shutting down the networkinterface.

(I think it depends on the underlying Kerberosimplemention what happens,
I'm using MIT 1.3).

> I'd suggest to either skip all tests that require networking unless some
> condition is met, for example if $ENV{TEST_ONLINE} is set, or to be
> smarter and try to detect if a network connection is available when
> running the test suite.

Skipping tests on some conditions is no problem,
I can add that.

But I dont't know *what* condition to test.
Sure I can test if $ENV{TEST_ONLINE} is set, but who or what software
sets that System-variable?

Can you help me and answer what's the condition to test to?

Achim

#	Sat May 27 11:13:27 2006	RT_System - Status changed from 'new' to 'open'

#

Sat May 27 11:19:49 2006

FLORA - Correspondence added

CC:	bug-GSSAPI[...]rt.cpan.org, perlgssapi-developer[...]lists.sourceforge.net, Daniel Schepler <schepler[...]math.berkeley.edu>
Subject:	Re: [rt.cpan.org #19524]
Date:	Sat, 27 May 2006 17:18:14 +0200
To:	Achim Grolms <achim[...]grolmsnet.de>
From:	Florian Ragwitz <rafl[...]debian.org>

[text/plain 927b]

On Sat, May 27, 2006 at 05:12:12PM +0200, Achim Grolms wrote:
> On Saturday 27 May 2006 16:15, Florian Ragwitz via RT wrote:
> > I'd suggest to either skip all tests that require networking unless some
> > condition is met, for example if $ENV{TEST_ONLINE} is set, or to be
> > smarter and try to detect if a network connection is available when
> > running the test suite.
>
> Skipping tests on some conditions is no problem,
> I can add that.
>
> But I dont't know *what* condition to test.
> Sure I can test if $ENV{TEST_ONLINE} is set, but who or what software
> sets that System-variable?

The user. Just like those pod and podcoverage test lots of people use
nowadays.

Those tests usually get skiped unless $ENV{TEST_POD} is set and the SKIP
message tells the user that, if he wants pod testing, he needs to set
that variable.

-Flo

--
BOFH excuse #392:
It's union rules. There's nothing we can do about it. Sorry.

[application/pgp-signature 189b]

Message body not shown because it is too large or is not plain text.

#

Sat May 27 12:15:15 2006

achim[...]grolmsnet.de - Correspondence added

CC:	bug-GSSAPI[...]rt.cpan.org, perlgssapi-developer[...]lists.sourceforge.net
Subject:	Re: [rt.cpan.org #19524]
Date:	Sat, 27 May 2006 18:14:22 +0200
To:	Daniel Schepler <schepler[...]math.berkeley.edu>, rafl[...]debian.org
From:	Achim Grolms <achim[...]grolmsnet.de>

[text/plain 782b]

On Saturday 27 May 2006 17:19, Florian Ragwitz via RT wrote:
> Queue: GSSAPI
> Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=19524 >

> Those tests usually get skiped unless $ENV{TEST_POD} is set and the SKIP
> message tells the user that, if he wants pod testing, he needs to set
> that variable.

I've had a look into tho t/test.t file:
The problem is the usage of gss_nt_service_name
in import() what makes the test always using the DNS.
(What fails if DNS it not available).

I have changed that (not to use DNS),
tested with MIT and Heimdal,
commitet changes to SVN Rep.

https://svn.sourceforge.net/svnroot/perlgssapi/GSSAPI/trunk

Please let me know if that changes work for you,
I will release GSSAPI 0.22 to CPAN if you think it works.

Thank you,
Achim

[application/pgp-signature 189b]

Message body not shown because it is too large or is not plain text.

#	Sun May 28 08:59:28 2006	AGROLMS - Subject changed from (no value) to 't/test.t fails if DNS is not available'

#

Mon May 29 08:35:55 2006

FLORA - Correspondence added

CC:	Daniel Schepler <schepler[...]math.berkeley.edu>, bug-GSSAPI[...]rt.cpan.org, perlgssapi-developer[...]lists.sourceforge.net
Subject:	Re: [rt.cpan.org #19524]
Date:	Mon, 29 May 2006 14:33:56 +0200
To:	Achim Grolms <achim[...]grolmsnet.de>
From:	Florian Ragwitz <rafl[...]debian.org>

[text/plain 1001b]

On Sat, May 27, 2006 at 06:14:22PM +0200, Achim Grolms wrote:
> On Saturday 27 May 2006 17:19, Florian Ragwitz via RT wrote:
> > Queue: GSSAPI
> > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=19524 >
>
> > Those tests usually get skiped unless $ENV{TEST_POD} is set and the SKIP
> > message tells the user that, if he wants pod testing, he needs to set
> > that variable.
>
> I've had a look into tho t/test.t file:
> The problem is the usage of gss_nt_service_name
> in import() what makes the test always using the DNS.
> (What fails if DNS it not available).
>
> I have changed that (not to use DNS),
> tested with MIT and Heimdal,
> commitet changes to SVN Rep.
>
> https://svn.sourceforge.net/svnroot/perlgssapi/GSSAPI/trunk
>
> Please let me know if that changes work for you,
> I will release GSSAPI 0.22 to CPAN if you think it works.

I verified that your changes fix the problem.

Thanks,
Flo

--
BOFH excuse #103:
operators on strike due to broken coffee machine

[application/pgp-signature 189b]

Message body not shown because it is too large or is not plain text.

#

Mon May 29 18:38:33 2006

AGROLMS - Correspondence added

[text/plain 44b]

Changes released to CPAN as 0.22

Achim

#	Mon May 29 18:38:34 2006	AGROLMS - Status changed from 'open' to 'resolved'

#	Tue May 30 21:26:50 2006	AGROLMS - Fixed in 0.22 added